fix(react): disable no-await-sync-events by default
#984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage 96.27% 96.27%
=======================================
Files 46 46
Lines 2472 2472
Branches 1025 1030 +5
=======================================
Hits 2380 2380
Misses 92 92 ☔ View full report in Codecov by Sentry. |
eps1lon
force-pushed
the
disable-no-await-sync-events
branch
from
6201fe8 to
c22f128
Compare
`@testing-library/react` will require `await act()`. At that point the rule is useless. Kept for backwards compatibility.
eps1lon
force-pushed
the
disable-no-await-sync-events
branch
from
c22f128 to
2c39396
Compare
1 task
Belco90
changed the title
testing-library/no-await-sync-events by defaultno-await-sync-events by default
|
Hi @eps1lon! Thanks for this PR and sharing context, I wasn't aware of such change. |
Belco90
approved these changes
Jan 29, 2025
|
It hasn't landed yet. This is just preparation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@testing-library/reactwill requireawait act(). At that point the rule is useless. Kept for backwards compatibility.Context
testing-library/react-testing-library#1214