Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-manual-cleanup): properly check all @testing-library imports #934

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Oct 8, 2024

Checks

Changes

  • Changes no-manual-cleanup so it checks every import rather than just the first one

Context

Currently the rule assumes the first @testing-library import will be one with a cleanup, which isn't true

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (93a6ab9) to head (dfa7dfd).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
+ Coverage   96.23%   96.28%   +0.04%     
==========================================
  Files          44       44              
  Lines        2419     2449      +30     
  Branches     1000     1018      +18     
==========================================
+ Hits         2328     2358      +30     
  Misses         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelDeBoey MichaelDeBoey added the bug Something isn't working label Oct 16, 2024
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

@Belco90 Belco90 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into testing-library:main with commit 62a3f61 Oct 17, 2024
31 checks passed
Copy link

🎉 This PR is included in version 6.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants