Skip to content

test: add type tests for within #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 2 commits into from
Oct 1, 2021
Merged

test: add type tests for within #1044

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8df69f3
test: add type tests for within
timdeschryver Sep 30, 2021
3dca6f9
refactor: rename sut to container
timdeschryver Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions types/__tests__/type-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
waitForElementToBeRemoved,
MatcherOptions,
BoundFunctions,
within,
} from '@testing-library/dom'

const {
Expand Down Expand Up @@ -228,6 +229,18 @@ export async function testWaitFors() {
await waitFor(async () => {})
}

export async function testWithin() {
const sut = within(document.body)
Copy link
Member

@eps1lon eps1lon Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "sut"?

Copy link
Member Author

@timdeschryver timdeschryver Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an abbreviation for "System Under Test", I couldn't think of a better name.
I can change it if you want though.

Copy link
Member

@eps1lon eps1lon Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please 😄

Copy link
Member Author

@timdeschryver timdeschryver Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, renamed to container.

sut.queryAllByLabelText('Some label')

sut.getByText('Click me')
sut.getByText<HTMLButtonElement>('Click me')
sut.getAllByText<HTMLButtonElement>('Click me')

await sut.findByRole('button', {name: /click me/i})
sut.getByRole<HTMLButtonElement>('button', {name: /click me/i})
}

/*
eslint
@typescript-eslint/no-unnecessary-condition: "off",
Expand Down