Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update comment in add-commands #128

Merged
merged 1 commit into from
Mar 10, 2020
Merged

chore: update comment in add-commands #128

merged 1 commit into from
Mar 10, 2020

Conversation

frederickfogerty
Copy link
Contributor

What: Outdated comment in source code

Why: The comment referenced an outdated library

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged

kentcdodds
kentcdodds approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@kentcdodds kentcdodds merged commit b82a673 into testing-library:master Mar 10, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @frederickfogerty for code

@allcontributors allcontributors bot mentioned this pull request Mar 10, 2020
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @frederickfogerty! 🎉

@frederickfogerty frederickfogerty deleted the patch-1 branch March 10, 2020 22:53
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederickfogerty @kentcdodds