Reduce use of deprecated distutils module
#353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per PEP 632, `distutils` is deprecated and most uses of it can be replaced by `setuptools`. The only use within `testtools` is to support the deprecated `TestCommand` that's due to be removed in the next major, but in the meantime, adding a runtime dependency on `setuptools` for Python 3.12+ (which removed `distutils` entirely) allows it to continue working.
|
Hi, thanks for the fix! |
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this pull request
May 20, 2024
For Python 3.12, stestr does not work unless testtools >= 2.7.0 See: https: //github.com/testing-cabal/testtools/pull/353/commits/18e1a7157562b00655561ee25ce0b41d383b2ed1 Change-Id: Idd599d80573f4740a4729d27106c329cc13ac25c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per PEP 632,
distutilsis deprecated and most uses of it can be replaced bysetuptools. The only use withintesttoolsis to support the deprecatedTestCommandthat's due to be removed in the next major, but in the meantime, adding a runtime dependency onsetuptoolsfor Python 3.12+ (which removeddistutilsentirely) allows it to continue working.Fix #352.