Report errors by console-logging and exit code #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripty is presently swallowing errors. This behavior was introduced with d7a1296 presumably to silence noisy errors caused by the scripts themselves. However, this has the side effect of _also_ muting errors raised by scripty itself. For instance, the common error of scripty being invoked but unable to find a script to execute. In such a scenario, (even when not silent), the only output printed is: ``` $ npm run bar > [email protected] bar /path/to/foo > scripty ``` What's worse, it exits with a zero (successful) status code. This change ensures errors from scripty are logged to STDERR and exits with a nonzero status code. It _also_ makes any script errors a bit noisier (as they were before), but that should be resolved separately with the more configurable logging levels.
|
Code Climate has analyzed commit a0e878a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 99.3% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripty is presently swallowing errors.
This behavior was introduced with d7a1296
presumably to silence noisy errors caused by the scripts themselves.
However, this has the side effect of also muting errors raised by
scripty itself.
For instance, the common error of scripty being invoked but unable to
find a script to execute. In such a scenario, (even when not silent),
the only output printed is:
What's worse, it exits with a zero (successful) status code.
This change ensures errors from scripty are logged to STDERR and exits
with a nonzero status code.
It also makes any script errors a bit noisier (as they were before),
but that should be resolved separately with the more configurable
logging levels.