Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up exits. #50

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Clean up exits. #50

merged 1 commit into from
Aug 29, 2017

Conversation

Schoonology
Copy link
Contributor

If a script exits with a non-zero code, scripty will no longer throw a noisy error.

Furthermore, setting process.exitCode allows the process tree to terminate normally, rather than forcibly killing it with process.exit().

If a script exits with a non-zero code, scripty should not throw a noisy error.

Furthermore, setting process.exitCode allows the process tree to terminate
normally, rather than forcibly killing it with process.exit().
@searls
Copy link
Member

searls commented Aug 29, 2017

Awesome, I didn't know about the process.exitCode assignment trick. Thanks Schoon!

@searls searls merged commit 365340f into master Aug 29, 2017
@searls searls deleted the no-throw-on-error branch August 29, 2017 12:43
@searls
Copy link
Member

searls commented Aug 29, 2017

Landed in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants