Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all configuration via package.json. #39

Merged
merged 3 commits into from
Oct 18, 2016
Merged

Allow all configuration via package.json. #39

merged 3 commits into from
Oct 18, 2016

Conversation

Schoonology
Copy link
Contributor

Options like silent have not previously been available in package.json (alongside path, for example). This changes that.

While the style may leave something to be desired, the function is all here, and I can style it how you like.

@searls
Copy link
Member

searls commented May 22, 2016

Cool deal, but I have a couple challenges if you're up for it prior to merging:

  • tests
  • README notes
  • a way to flip the package.json setting setting the matching env var to exactly false. that is, if {scripty: { parallel: true } } is set, then I should be able to override it with SCRIPTY_PARALLEL=false npm run lol ad hoc

Thoughts?

@searls
Copy link
Member

searls commented May 22, 2016

Also, as punishment for submitting a PR to this project I was planning on giving you commit bit to the project, but you already have it.

@sheerun
Copy link

sheerun commented Oct 17, 2016

it would be nice to merge

@searls
Copy link
Member

searls commented Oct 18, 2016

I blame @Schoonology for not chiming in with a comment after adding tests -- just added a readme. will merge when the build passes

@searls searls merged commit b033fb0 into master Oct 18, 2016
@searls
Copy link
Member

searls commented Oct 18, 2016

Landed in 1.7.0 -- thanks @Schoonology!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants