Fix explicit parent script for index files with an extension #22

searls · 2016-04-16T13:58:37Z

Reproduce @boneskull's bug in "explicit parent script" not working #20
Fix bug
Research comments on windows compatibility (at least the windows build passes)

* Rewrite generate-globs unit test now that it does a different thing * Refactor a bunch of names * Move unit-test-specific fixtures into their own dir to avoid confusion * Demarcate unit-test fixtures from one another so they don't become tangled with one another and can be changed/deleted safely * Write a "multi-glob" module which will accept multiple globbing patterns and return the first hit. This allows us to avoid the stat calls or moving glob.sync calls elsewhere

(Really just hoping this fixes the windows build w/o much hard thought)

searls · 2016-04-16T18:17:49Z

Seems like an improvement. Thanks a lot to @boneskull raising the issue!

Reproduce @boneskull's bug in #20

728f7c5

searls force-pushed the 20-fix-explicit-parent-script branch from 53a331a to 97c2581 Compare April 16, 2016 16:44

searls force-pushed the 20-fix-explicit-parent-script branch from 97c2581 to d3a1420 Compare April 16, 2016 17:57

Be extra windows cautious

74ebf6c

(Really just hoping this fixes the windows build w/o much hard thought)

searls merged commit c98c76f into master Apr 16, 2016

searls deleted the 20-fix-explicit-parent-script branch April 16, 2016 18:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix explicit parent script for index files with an extension #22

Fix explicit parent script for index files with an extension #22

searls commented Apr 16, 2016 •

edited

Loading

searls commented Apr 16, 2016

Fix explicit parent script for index files with an extension #22

Fix explicit parent script for index files with an extension #22

Conversation

searls commented Apr 16, 2016 • edited Loading

searls commented Apr 16, 2016

searls commented Apr 16, 2016 •

edited

Loading