Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-provided args #12

Merged
merged 7 commits into from
Apr 15, 2016
Merged

Allow user-provided args #12

merged 7 commits into from
Apr 15, 2016

Conversation

searls
Copy link
Member

@searls searls commented Apr 15, 2016

Continuing to riff on @deanius's improvements in #6

Resolves #5

Dean Radcliffe and others added 3 commits April 11, 2016 20:45
Verify that user-provided args are passed through if script references $@

Readme and cleanup
This isn't the right place or time, but I really hated the
lack of default option merging, and caught an issue that
two-arg invocation would pass the callback function as options.

* move scripty into lib/scripty so we can write a test for it
later
* create a wrapper function for normalizing args to a standard
node module interface (default options, two arg invocation, etc)
* pull up the argv slicing to cli.js
@searls searls merged commit 46fe392 into master Apr 15, 2016
@searls searls deleted the deanius-pass-through-args branch April 15, 2016 02:42
@searls
Copy link
Member Author

searls commented Apr 15, 2016

Landed in 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant