Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when scripty is run outside npm run #9

Closed
searls opened this issue Apr 12, 2016 · 1 comment
Closed

Handle when scripty is run outside npm run #9

searls opened this issue Apr 12, 2016 · 1 comment

Comments

@searls
Copy link
Member

searls commented Apr 12, 2016

I had previously given no thought to what to do when the $npm_lifecycle_event var isn't provided.

  1. When no CLI args are passed, bomb out as unsupported and print usage instructions
  2. When scripty is run like scripty test:unit assume that first arg is the lifecycle event name (is this a good idea? Might be risky to encourage people to run scripts outside the contextof all those npm environment tweaks)
@searls
Copy link
Member Author

searls commented Apr 15, 2016

Decided the best thing to do for the forseeable future is to print a helpful error. Running scripty this way would be an edge case and a vector for support issues that aren't worth worrying ourselves about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant