Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix travis #3

Closed
searls opened this issue Apr 9, 2016 · 5 comments
Closed

Fix travis #3

searls opened this issue Apr 9, 2016 · 5 comments
Labels
bug

Comments

@searls
Copy link
Member

searls commented Apr 9, 2016

Build #worksforme. I suspect issues on travis are linux or pathname related.
@searls searls added the bug label Apr 9, 2016
@fyockm
Copy link

fyockm commented Apr 10, 2016

Why still bother testing for iojs on Travis? Perhaps add v5 or just wait till 'v6' instead?

@searls
Copy link
Member Author

searls commented Apr 10, 2016

Thanks. I just picked a few at random to start with, because I haven't decided what to support yet. I'll probably end up with 0.10, 4, and 5.

There are ton of issues with this thing on 0.10 so I'm currently working on those

@searls
Copy link
Member Author

searls commented Apr 10, 2016

OK, I think I've got all the 0.10 issues squared away (and can pass npm test locally with it).

The rest of these build failures appear to be linux vs osx issues pertaining to file permissions & fs.stats: https://travis-ci.org/testdouble/scripty/builds/121997397

@searls
Copy link
Member Author

searls commented Apr 10, 2016

Published 1.0.1 to get the 0.10 fixes out asap while looking at the rest

@searls
Copy link
Member Author

searls commented Apr 10, 2016

Fixed the build issues, they were:

  1. Missing fixtures directories (empty on my machine so git missed them)
  2. Mismatced uid/guid ACLs on other fixture files (now chmod'ing within the test)

@searls searls closed this as completed Apr 10, 2016
searls added a commit that referenced this issue Apr 16, 2016
@searls
Attempt to use power-assert.
7ab154e 
Throws the same error that it has thrown:

```
not ok 3 - "modeSwitchCapturesLogs" - test #3 in `lib/log.test.js`
  ---
  message: assert._capt is not a function
  stacktrace: TypeError: assert._capt is not a function
    at [object Object].module.exports.modeSwitchCapturesLogs (lib/log.test.js:26:18)
    at /Users/justin/code/testdouble/scripty/node_modules/teenytest/lib/user-function-async-wrapper-factory.js:10:22
    at /Users/justin/code/testdouble/scripty/node_modules/teenytest/node_modules/async/lib/async.js:718:13
    at Immediate.iterate [as _onImmediate] (/Users/justin/code/testdouble/scripty/node_modules/teenytest/node_modules/async/lib/async.js:262:13)
    at processImmediate [as _immediateCallback] (timers.js:374:17)
  ...
```

My `npm version`:

```
{ scripty: '1.2.2',
  npm: '2.14.4',
  ares: '1.10.1-DEV',
  http_parser: '2.5.0',
  modules: '46',
  node: '4.1.1',
  openssl: '1.0.2d',
  uv: '1.7.4',
  v8: '4.5.103.33',
  zlib: '1.2.8' }
```
searls added a commit that referenced this issue Apr 16, 2016
@searls
Attempt to use power-assert.
c1e2d73 
Throws the same error that it has thrown:

```
not ok 3 - "modeSwitchCapturesLogs" - test #3 in `lib/log.test.js`
  ---
  message: assert._capt is not a function
  stacktrace: TypeError: assert._capt is not a function
    at [object Object].module.exports.modeSwitchCapturesLogs (lib/log.test.js:26:18)
    at /Users/justin/code/testdouble/scripty/node_modules/teenytest/lib/user-function-async-wrapper-factory.js:10:22
    at /Users/justin/code/testdouble/scripty/node_modules/teenytest/node_modules/async/lib/async.js:718:13
    at Immediate.iterate [as _onImmediate] (/Users/justin/code/testdouble/scripty/node_modules/teenytest/node_modules/async/lib/async.js:262:13)
    at processImmediate [as _immediateCallback] (timers.js:374:17)
  ...
```

My `npm version`:

```
{ scripty: '1.2.2',
  npm: '2.14.4',
  ares: '1.10.1-DEV',
  http_parser: '2.5.0',
  modules: '46',
  node: '4.1.1',
  openssl: '1.0.2d',
  uv: '1.7.4',
  v8: '4.5.103.33',
  zlib: '1.2.8' }
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@searls @fyockm