feat: add Microsoft SQL Server module
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kymmt90
changed the title
DDtKey
changed the title
Microsoft SQL Server image
DDtKey
changed the title
Microsoft SQL Server imageMicrosoft SQL Server module
DDtKey
reviewed
Nov 28, 2023
|
I'll take a look at the CI failures... |
|
The failed tests sometimes tried to login before master db (a system db where SA user is in) was recovered and got auth errors. Fixed @DDtKey Could you please run CI again for this changes? |
DDtKey
reviewed
Nov 29, 2023
DDtKey
approved these changes
Nov 29, 2023
Merged
DDtKey
pushed a commit
that referenced
this pull request
Nov 29, 2023
## 🤖 New release * `testcontainers-modules`: 0.1.4 -> 0.2.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.2.0] - 2023-11-29 ### Features - Add `Microsoft SQL Server` module ([#72](#72)) ### Miscellaneous Tasks - [**breaking**] Update `elasticmq` default image version ([#73](#73)) - Bump the aws-dependencies group with 5 updates ([#71](#71)) <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thanks for all efforts to get it merged! New version has been released and available on crates.io |
|
Thank you! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Microsoft SQL Server module based on the official Docker images.
https://hub.docker.com/_/microsoft-mssql-server
Thanks!