Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): create_label test #771

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neykov
Copy link
Contributor

@neykov neykov commented Feb 12, 2025

Make sure the test covers the intended behaviour. Previously it was executing the create_labels function without actually verifying there are no side effects.

Make sure the test covers the intended behaviour. Previously it was executing the create_labels function without actually verifying there are no side effects.
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@b1642e9). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #771   +/-   ##
=======================================
  Coverage        ?   85.32%           
=======================================
  Files           ?       12           
  Lines           ?      668           
  Branches        ?      105           
=======================================
  Hits            ?      570           
  Misses          ?       75           
  Partials        ?       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neykov neykov changed the title Fix for create_label test fix(core): create_label test Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant