-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix node 20 pipeline #728
Fix node 20 pipeline #728
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @javierlopezdeancos, will merge when the build passes
Hi @cristianrgreco any ideas about why this job is failing in the Couchbase module? https://github.com/testcontainers/testcontainers-node/actions/runs/8284679078/job/22698328589?pr=728 |
I've looked into the test failures, seems it's specific to node 20 |
I found that tc-java have the same issue |
…into 727-install-node-dependencies-action-are-not-taking-right-node-js-version
Install Node js dependency action should install the right Node js version per action description
We can see it in each job that execute test with different Node js versions
I think that there is an error in the job github template, fixing it we have the expected behavior, installing the right node version
Close #727