Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #801: Class org.testcontainers.shaded.javax.annotation.CheckForNull not found #802

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Fixes #801: Class org.testcontainers.shaded.javax.annotation.CheckForNull not found #802

merged 1 commit into from
Jul 30, 2018

Conversation

alesavin
Copy link
Contributor

No description provided.

@alesavin alesavin changed the title Fixes #801 Fixes #801: Class org.testcontainers.shaded.javax.annotation.CheckForNull not found Jul 29, 2018
rnorth
rnorth approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and the clear explanation on #801.

I shall merge; thank you!

@rnorth rnorth merged commit ba8a89f into testcontainers:master Jul 30, 2018
rnorth added a commit that referenced this pull request Jul 30, 2018
@rnorth
Revert "Fixes #801: Class org.testcontainers.shaded.javax.annotation.…
482e962 
…CheckForNull not found (#802)"

This reverts commit ba8a89f.
@rnorth rnorth mentioned this pull request Jul 30, 2018
Merged
rnorth added a commit that referenced this pull request Jul 30, 2018
@rnorth
Revert "Fixes #801: Class org.testcontainers.shaded.javax.annotation.…
35c5046 
…CheckForNull not found" (#809)

Reverts #802

Sorry @alesavin - post-merge, we realised we want to do a bit more digging on this issue. We'll still try and, very soon, either (a) fix the problem another way, or (b) re-add this.
rnorth added a commit that referenced this pull request Jul 31, 2018
@rnorth
Revert changelog mention of #802
e1bf156
@rnorth rnorth mentioned this pull request Jul 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alesavin @rnorth