-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fluent builders #657
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
force-pushed
the
fix-fluent-builders
branch
3 times, most recently
from
April 23, 2018 21:58
2489760
to
06833ef
Compare
@arteam could you please check why the tests are failing on CircleCI? |
and
Looks like some internal Circle CI failures, I will retry the build. UPD: Looks like Circle CI is experiencing problems right now, I can't start a build. |
arteam
force-pushed
the
fix-fluent-builders
branch
from
April 26, 2018 22:37
3886fef
to
06833ef
Compare
I personally like removing the generic SELF - makes it much readable IMO - 👍 |
arteam
force-pushed
the
fix-fluent-builders
branch
from
April 30, 2018 20:35
06833ef
to
cb1db2c
Compare
Currently many containers (JDBC based, Nginx, Vault) are not very great as fluent builders. They are all parametrized, that means the user has to instance them with the sqare brackets to denote the type. That's not intuitive, and the Testcontainers docs don't mention it anywhere. Moreover, the compiler still complains about raw types, because we can't declare a container variable parametrized by itself. If we don't parametrize the container, than we can't invoke the methods of `GenericContainer` without losing the call chain. The compiler doesn't know about the concrete type of the builder. For example, for `MySQLContainer` this causes a compiler error: ``` MySQLContainer container = new MySQLContainer("mysql:5.7") .withClasspathResourceMapping("/mysql-initdb", "/docker-entrypoint-initdb.d", BindMode.READ_ONLY) .withDatabaseName("test-warehouse"); ``` A solution is not to parametrize concrete containers and let the type propagate to `GenericContainer`.
arteam
force-pushed
the
fix-fluent-builders
branch
from
April 30, 2018 20:51
cb1db2c
to
bc5cd52
Compare
@bsideup Thanks, I've rebased my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently many containers (JDBC based, Nginx, Vault) are not very great as fluent builders. They are all parametrized, that means the user has to instance them with the sqare brackets to denote the type.
That's not intuitive, and the Testcontainers docs don't mention it anywhere. Moreover, the compiler still complains about raw types, because we can't declare a container variable parametrized by itself.
If we don't parametrize the container, than we can't invoke the methods of
GenericContainer
without losing the call chain. The compiler doesn't know about the concrete type of the builder. For example,for
MySQLContainer
this causes a compiler error:A solution is not to parametrize concrete containers and let the type propagate to
GenericContainer
.