Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic around checkExposedPort pre-flight check #516

Merged
merged 1 commit into from
Dec 18, 2017

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Dec 11, 2017

… for improved robustness (fixes #513).

@rnorth rnorth requested a review from bsideup December 11, 2017 20:28
@rnorth
Copy link
Member Author

rnorth commented Dec 11, 2017

#513 sounds like a challenging one to reproduce - it's not something I've seen before. Based on the code, a Null Pointer Exception should not be raised if things are working. It must only happen if the exposed port check is already on the way to failing. Because it's an intermittent issue, it seems there might be a timing issue.

With this PR I've added a simple, 3 second, retry loop around the port check logic. It's hard to know if this will help, but it's probably the most we can do to try and resolve without a way to reproduce.

@VladoDemcak
Copy link

thanks for fix @rnorth. I see this change in CHANGELOG.mdas implemented in 1.5.0 but we are using latest 1.5.0 from maven central repository and It's not here. Also I see this PR as open.

@rnorth
Copy link
Member Author

rnorth commented Dec 18, 2017

Damn, sorry - not sure what happened here, but undoubtedly my fault. Will release with this included ASAP.

… robustness (fixes #513).

Fix erroneous changelog entry for 1.5.0 release
@rnorth rnorth force-pushed the fix-513-checkExposedPort-retries branch from 01819c7 to c9c2109 Compare December 18, 2017 14:15
@rnorth rnorth merged commit 6d42f41 into master Dec 18, 2017
@rnorth rnorth deleted the fix-513-checkExposedPort-retries branch December 18, 2017 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnable to start container - checkExposedPort - NullPointerException
3 participants