Using correct driver for mysqlconnectorj#1645
Closed
tomaytotomato wants to merge 3 commits intotestcontainers:masterfrom
tomaytotomato:master
Closed
Using correct driver for mysqlconnectorj#1645tomaytotomato wants to merge 3 commits intotestcontainers:masterfrom tomaytotomato:master
tomaytotomato wants to merge 3 commits intotestcontainers:masterfrom
tomaytotomato:master
Conversation
MySQLContainer now uses the correct mysql driver package, stop warnings
rnorth
requested changes
Aug 10, 2019
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
Thanks for the contribution @tomaytotomato.
However, this would seem to be a breaking change if people have older versions of the driver on their classpath. There was a suggestion in #1655 to do some slightly more involved but compatible logic to detect which driver to use.
Would you be able to try this approach instead?
Member
|
This was fixed in #1760, which is being released now in https://github.com/testcontainers/testcontainers-java/releases/tag/1.12.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQLContainer now uses the correct mysql driver package, stop warnings