Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note about JDBC driver #304

Merged
merged 2 commits into from
Mar 3, 2017
Merged

Conversation

mihhail-lapushkin
Copy link
Contributor

For me it did not work with Spring Boot until I changed the driver:
spring.datasource.driver-class-name=org.testcontainers.jdbc.ContainerDatabaseDriver

Not sure if this is needed in general.

PS: ignore line 115, seems like a glitch :)

For me it did not work with Spring Boot until I changed the driver:
spring.datasource.driver-class-name=org.testcontainers.jdbc.ContainerDatabaseDriver

Not sure if this is needed in general.
@rnorth
Copy link
Member

rnorth commented Mar 3, 2017

Thanks - this looks good to me. I suspect there might be a couple of other cases where it's necessary to set the driver name, but I can't think of what they'd be off the top of my head. I'll merge this, and have raised #305 for further checks/updates.

@rnorth rnorth merged commit 932a60b into testcontainers:master Mar 3, 2017
rnorth added a commit that referenced this pull request Mar 12, 2017
## [1.2.0] - 2017-03-12
### Fixed
- Fix various escaping issues that may arise when paths contain spaces (#263, #279)
- General documentation fixes/improvements (#300, #303, #304)
- Improve reliability of `ResourceReaper` when there are a large number of containers returned by `docker ps -a` (#295)

### Changed
- Support Docker for Windows via TCP socket connection (#291, #297, #309). _Note that Docker Compose is not yet supported under Docker for Windows (see #306)
- Expose `docker-java`'s `CreateContainerCmd` API for low-level container tweaking (#301)
- Shade `org.newsclub` and Guava dependencies (#299, #292)
- Add `org.testcontainers` label to all containers created by Testcontainers (#294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants