Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker for Windows support #291

Closed
Villane opened this issue Feb 13, 2017 · 6 comments
Closed

Docker for Windows support #291

Villane opened this issue Feb 13, 2017 · 6 comments
Labels
client/docker-for-windows

Comments

@Villane
Copy link

Villane commented Feb 13, 2017

Would be nice to get support for Docker for Windows.

I switched to Docker for Windows recently, and now I can't run our testcontainers tests locally, because it seems one can't use VirtualBox and Hyper-V at the same time for Docker on Windows 10.
@kiview
Copy link
Member

kiview commented Feb 17, 2017

I think the underlying docker-java library provided basic support for Windows by specifying DOCKER_HOST=tcp://127.0.0.1:2376, not a smooth experience, but it worked.

Maybe this setup is simply not considered a valid environment when determining the strategy, although it might work in theory?

@bsideup
Copy link
Member

bsideup commented Feb 21, 2017

@kiview did you try tcp? How is it so far?

@bsideup bsideup mentioned this issue Feb 21, 2017
Closed
@kiview
Copy link
Member

kiview commented Feb 21, 2017

It works fine with the docker-java client, but testcontainers doesn't recognize the environment based of this parameters it seems.

@bsideup
Copy link
Member

bsideup commented Feb 21, 2017

@kiview ok, cool. @Villane is sitting next to me, I'll try to fix TestContainers on his machine then :) Or did you plan to contribute Docker for Windows support? I got lost a bit :)

@kiview
Copy link
Member

kiview commented Feb 21, 2017

@bsideup yes, I was indeed planning to help with Docker for Windows support, but that's not high on my priority list right now, since we are using Linux after all. I just think this shouldn't be too hard, since there are already valid workarounds regarding docker-java and docker-groovy of how to achieve this.

bsideup added a commit that referenced this issue Feb 21, 2017
@bsideup
#291 basic named pipe support
0e093e4
bsideup added a commit that referenced this issue Feb 21, 2017
@bsideup
#291 close streams
153e187
bsideup added a commit that referenced this issue Feb 21, 2017
@bsideup
#291 create ServerSocket outside of the task
3d871ab
bsideup added a commit that referenced this issue Feb 21, 2017
@bsideup
#291 do not extend UnixSocketClientProviderStrategy
c7a4fae
bsideup added a commit that referenced this issue Feb 21, 2017
@bsideup
#291 create RandomAccessFile for each accepted connection
c819aba
bsideup added a commit that referenced this issue Feb 21, 2017
@bsideup
#291 more cleanups
6c5d14e
bsideup added a commit that referenced this issue Feb 21, 2017
@bsideup
#291 and even more cleanups
373e54d
bsideup added a commit that referenced this issue Feb 21, 2017
@bsideup
#291 stupid me.
04ec098
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
0d218d3
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug (2)
7cb48f9
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug (3)
f8a2c03
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug (4)
fa7e9d9
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 use ByteStreams
ed0f64d
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 more debug
60cfc50
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 manual ping
71f15d7
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 manual ping(2)
17c55c6
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 manual ping(3)
da2a82b
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 change order
df7049e
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 create all streams at once
a205ab1
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
ce3d621
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
b4925cf
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
8de4aea
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
ed8900c
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
5bd7efa
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
d15b41e
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
4cf8a91
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
bd30230
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
b8cd5db
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 21, 2017
@bsideup
testcontainers#291 debug
4e8aa11
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
456d420
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
7d4f56b
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
96e3538
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
8acb68d
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
fbe2f12
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 use NamedPipeSocket from MariaDB
d6a24c4
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 oops
f3545ea
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 oops
541318f
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
6866d4b
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
fe53d07
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
40d239a
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
1d31617
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
2ba2e8b
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 debug
feff8da
bsideup added a commit to bsideup/testcontainers-java that referenced this issue Feb 22, 2017
@bsideup
testcontainers#291 Docker for Windows support over TCP
63a57d6
bsideup added a commit that referenced this issue Feb 22, 2017
@bsideup
#291 relax the condition
73accee
bsideup added a commit that referenced this issue Feb 22, 2017
@bsideup
Closes #291 change the docs
7fbec54
@Villane
Copy link
Author

Villane commented Feb 22, 2017

Generally seems to work with this PR #297

Getting some connection errors in our tests, but this might be on our side.

rnorth pushed a commit that referenced this issue Mar 3, 2017
@bsideup @rnorth
#291 Docker for Windows support over TCP
e8bf32e
rnorth pushed a commit that referenced this issue Mar 3, 2017
@bsideup @rnorth
#291 relax the condition
aaa1fda
@rnorth rnorth closed this as completed in b41a9f5 Mar 3, 2017
rnorth added a commit that referenced this issue Mar 12, 2017
@rnorth
Update CHANGELOG for 1.2.0 release:
1ef0193 
## [1.2.0] - 2017-03-12
### Fixed
- Fix various escaping issues that may arise when paths contain spaces (#263, #279)
- General documentation fixes/improvements (#300, #303, #304)
- Improve reliability of `ResourceReaper` when there are a large number of containers returned by `docker ps -a` (#295)

### Changed
- Support Docker for Windows via TCP socket connection (#291, #297, #309). _Note that Docker Compose is not yet supported under Docker for Windows (see #306)
- Expose `docker-java`'s `CreateContainerCmd` API for low-level container tweaking (#301)
- Shade `org.newsclub` and Guava dependencies (#299, #292)
- Add `org.testcontainers` label to all containers created by Testcontainers (#294)
@bderancourt bderancourt mentioned this issue Jun 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client/docker-for-windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Villane @bsideup @kiview