Skip to content

fix: should print max information by default #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −6
Open

fix: should print max information by default #3459

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
320b05e
should print max information by default
strowk Oct 30, 2025
e73e10e
correct comment
strowk Oct 30, 2025
fba533f
feat: expose noop logger
strowk Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions log/logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,17 @@ type Logger interface {
Printf(format string, v ...any)
}

// defaultLogger is the default Logger instance.
var defaultLogger Logger = &noopLogger{}
// defaultLogger would print available information to stderr
var defaultLogger Logger = log.New(os.Stderr, "", log.LstdFlags)

func init() {
// Enable default logger in the testing with a verbose flag.
if testing.Testing() {
// Parse manually because testing.Verbose() panics unless flag.Parse() has done.
// Disable logging if explicitly disabled via -test.v=false
for _, arg := range os.Args {
if strings.EqualFold(arg, "-test.v=true") || strings.EqualFold(arg, "-v") {
defaultLogger = log.New(os.Stderr, "", log.LstdFlags)
if strings.EqualFold(arg, "-test.v=false") {
Copy link

@ar-sematell ar-sematell Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Create a public constructor for the noopLogger, or remove it and use log.New(io.Discard, "", 0)

Copy link
Member

@mdelapenya mdelapenya Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strowk what are your thoughts on this?

Copy link
Author

@strowk strowk Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough - fba533f

defaultLogger = &noopLogger{}
break
}
}
}
Expand Down
Loading