Skip to content

chore(postgres): use require.NotNil instead of assert.NotNil #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2025
+2 −3
Merged

chore(postgres): use require.NotNil instead of assert.NotNil #3252

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6eeb8c6
chore: use require.NotNil instead of assert.NotNil
nolandseigler Aug 6, 2025
588bdd0
chore: remove use of assert
nolandseigler Aug 13, 2025
774913e
Merge branch 'main' into db-assert-to-require
mdelapenya Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/postgres/postgres_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func TestWithSSL(t *testing.T) {

db, err := sql.Open("postgres", connStr)
require.NoError(t, err)
assert.NotNil(t, db)
require.NotNil(t, db)
Copy link
Member

@mdelapenya mdelapenya Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: could you remove the entire assert import and replace it with require? 🙏

Other than than, LGTM

Copy link
Contributor Author

@nolandseigler nolandseigler Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely. will knock that out today. thanks!

Copy link
Contributor Author

@nolandseigler nolandseigler Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heres the update. 588bdd0.

defer db.Close()

result, err := db.Exec("SELECT * FROM testdb;")
Expand Down