feat: allow saving specific platforms for an image #3218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LaurentGoderre
force-pushed
the
save-image-multi-arch
branch
from
2dcc37c to
b5a1892
Compare
LaurentGoderre
changed the title
LaurentGoderre
force-pushed
the
save-image-multi-arch
branch
from
b5a1892 to
a1213e5
Compare
stevenh
reviewed
Jun 26, 2025
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Thanks for this, I've done a quick pass with a few improvement suggestions.
stevenh
requested changes
Jun 26, 2025
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Clicking the right option this time 😄
LaurentGoderre
force-pushed
the
save-image-multi-arch
branch
4 times, most recently
from
4c0121d to
b4b87f4
Compare
Contributor
Author
|
@stevenh updated! Thanks for the review! |
Contributor
Author
|
FYI, we are using a simplified version of this change internally for our tests without a problem |
stevenh
requested changes
Jun 30, 2025
neersighted
suggested changes
Jun 30, 2025
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
Beyond @stevenh's review which I concur with, I'd like to see this PR use string-specs for the platform (like the rest of the TC/Docker API) and use github.com/containerd/platforms.ParseAll() to transform them.
Member
|
For reference, we addressed this in the go-sdk too: https://pkg.go.dev/github.com/docker/go-sdk/image#SaveOption |
LaurentGoderre
force-pushed
the
save-image-multi-arch
branch
2 times, most recently
from
d464819 to
b43cced
Compare
Contributor
Author
|
@neersighted implemented your suggestion! |
LaurentGoderre
force-pushed
the
save-image-multi-arch
branch
2 times, most recently
from
0060e37 to
9c1d365
Compare
LaurentGoderre
force-pushed
the
save-image-multi-arch
branch
from
6f56fac to
878a7cd
Compare
LaurentGoderre
force-pushed
the
save-image-multi-arch
branch
from
878a7cd to
5bb524d
Compare
mdelapenya
reviewed
Sep 11, 2025
mdelapenya
previously approved these changes
Sep 11, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
I added a few comments, just typos.
Other than that, LGTM, thanks for this! And sorry for the late review, my fault 🙏
mdelapenya
approved these changes
Sep 15, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks!
@stevenh I saw your suggestions were addressed in this PR, that's why I'm merging it. Feel free to comment here if not, so we can do a follow-up 🙏
mdelapenya
added
the
feature
mdelapenya
added a commit
to prestonvasquez/testcontainers-go
that referenced
this pull request
Sep 17, 2025
* main: (22 commits) chore(deps): bump golang.org/x/net from 0.28.0 to 0.38.0 (testcontainers#3299) feat: allow saving specific platforms for an image (testcontainers#3218) chore(deps): bump dario.cat/mergo from 1.0.1 to 1.0.2 (testcontainers#3238) chore(deps): bump golang.org/x/sys from 0.32.0 to 0.36.0 (testcontainers#3282) feat(redpanda): add support for http proxy (testcontainers#3258) chore(deps): bump github/codeql-action from 3.29.3 to 3.30.3 (testcontainers#3287) chore(go): bump to Go 1.24 as minimal version (testcontainers#3298) deps(mongodb): update MongoDB Go Driver to v2 (testcontainers#3278) chore(deps): bump github.com/shirou/gopsutil/v4 from 4.25.5 to 4.25.6 (testcontainers#3224) chore(deps): bump mkdocs-include-markdown-plugin from 7.1.6 to 7.1.7 (testcontainers#3284) docs: clarify no client SDKs in production modules/images, in contributing.md (testcontainers#3279) chore(deps): bump github.com/docker/go-connections from 0.5.0 to 0.6.0 (testcontainers#3285) chore(deps): bump tj-actions/changed-files from 46.0.3 to 47.0.0 (testcontainers#3283) chore(modulegen): detect missing project files after new module creation (testcontainers#3281) chore(deps): bump github.com/docker/docker in /modules/nebulagraph (testcontainers#3277) feat(nebulagraph): add NebulaGraph module (testcontainers#3266) fix: preserve unix socket schema in testcontainers host from properties (testcontainers#3213) feat(registry): add helper functions to pull and tag images (testcontainers#3275) fix(reaper): remove termSignal override (testcontainers#3261) chore(deps): bump ryuk to v0.13.0, which uses scratch as base image (testcontainers#3274) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This introduces a way to pass image save options (like platform) to the image client. This allows saving a specific architecture for an image.
Why is it important?
With OCI multi-arch images, it is sometimes needed to save image for a different architecture than the current one. This changes allows to control the behavior instead of defaulting to the current platform.