chore(ci): use new GH action for SonarQube #3007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* main: chore(deps): bump github.com/opencontainers/image-spec from 1.1.0 to 1.1.1, dario.cat/mergo from 1.0.0 to 1.0.1 (testcontainers#3030) chore(deps): bump github/codeql-action from 3.28.0 to 3.28.11 (testcontainers#3014) chore(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 (testcontainers#3013) chore: readd dependabot, including a way to refresh the project files for all the modules (testcontainers#2997) docs: refine texts on how to set the module image (testcontainers#3012) feat(modules): add dind module (testcontainers#3004) docs: correct container variable (testcontainers#3010)
Member
Author
|
I'm going to merge this one and explore how it goes in the Sonarcloud instance. |
mdelapenya
added a commit
that referenced
this pull request
Mar 17, 2025
…er-28.0.1incompatible * main: chore!: export DockerCompose type in compose package (#2953) chore(deps): bump golang.org/x/net from 0.33.0 to 0.36.0 in /modules (#3033) chore(sonar): set main as default branch (#3038) fix(sonar): run on ubuntu and the lowest Go version (#3037) fix(ci): update core path in sonar build (#3036) fix: use empty dir for the core (#3035) fix: pass secret to the reusable workflow (#3034) chore(ci): use new GH action for SonarQube (#3007)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 17, 2025
* main: chore(deps)!: bump github.com/docker/docker from 27.1.1+incompatible to 28.0.1+incompatible (testcontainers#3017) chore!: export DockerCompose type in compose package (testcontainers#2953) chore(deps): bump golang.org/x/net from 0.33.0 to 0.36.0 in /modules (testcontainers#3033) chore(sonar): set main as default branch (testcontainers#3038) fix(sonar): run on ubuntu and the lowest Go version (testcontainers#3037) fix(ci): update core path in sonar build (testcontainers#3036) fix: use empty dir for the core (testcontainers#3035) fix: pass secret to the reusable workflow (testcontainers#3034) chore(ci): use new GH action for SonarQube (testcontainers#3007)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It uses the new SonarQube GH action, as the old one was deprecated. It generates the sonar properties on the fly, removing the need of maintaining a properties file with all the modules. As a result, the code generation tool for the sonar properties is removed in this PR.
Also, the project in Sonar will be a monorepo, having as project key:
testcontainers_testcontainers-gotestcontainers_testcontainers-go_modules_postgresand as project name:
testcontainers-gotestcontainers-go-modules-postgresAs a consequence, the sonar step will be executed per module, updating each project of the parent project with the given changes.
Why is it important?
Sonar is failing since March 4th 2025. Besides that, simplifying the maintenance of modules and collecting sonar metrics per module, not per monorepo.