Copy file out from a container #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bablzz
reviewed
Feb 2, 2021
| @@ -337,6 +337,29 @@ func (c *DockerContainer) CopyFileToContainer(ctx context.Context, hostFilePath | |||
| return c.provider.client.CopyToContainer(ctx, c.ID, filepath.Dir(containerFilePath), buffer, types.CopyToContainerOptions{}) | |||
| } | |||
|
|
|||
| func (c *DockerContainer) CopyFileFromContainer(ctx context.Context, containerFilePath string) (io.Reader, error) { | |||
| r, _, err := c.provider.client.CopyFromContainer(ctx, c.ID, containerFilePath) | |||
|
Hello!! Thanks a lot for your contribution! But I can't merge it without any unit test |
|
Thanks for tetting back to me. That looks perfect, I'll close this PR 👌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for copying files out of containers via an
io.Reader. I really need this functionality for a project that I'm working on, so I thought the quickest option was to fix it upstream. If this PR looks OK, I would love a new release 🙏🏻