fix: Do not create a Port Forwarding Container instance if auto-discovery does not detect Docker host #900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR prevents Testcontainers from creating a Port Forwarding Container instance if auto-discovery does not detect a Docker host.
Why is it important?
If users choose to configure their Docker host environment individually using the container builder method
WithDockerEndpoint
, Testcontainers will throw an exceptionif auto-discovery fails to find a Docker host environment. The port forwarding container depends on auto-discovery and cannot be customized for individual Docker host configurations since it is implemented as a singleton.
To enhance the user experience, we should consider removing feature
WithDockerEndpoint
. By relying on auto-discovery, we can better support a wide range of features in Testcontainers and simplify test configurations.Related issues
-