Skip to content

fix(Milvus): Use healthcheck wait strategy #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HofmeisterAn merged 3 commits into from
Nov 26, 2025
Merged

fix(Milvus): Use healthcheck wait strategy #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6589edd
fix(Milvus): wait for healthy
verdie-g Nov 23, 2025
b8c357a
chore: Use singleton implemenation
HofmeisterAn Nov 24, 2025
6bc7cd0
fix: Use correct wait strategy
HofmeisterAn Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/Testcontainers.Milvus/MilvusBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,9 @@ protected override MilvusBuilder Init()
.WithEnvironment("ETCD_CONFIG_PATH", MilvusEtcdConfigFilePath)
.WithEnvironment("ETCD_DATA_DIR", "/var/lib/milvus/etcd")
.WithResourceMapping(EtcdConfig, MilvusEtcdConfigFilePath)
.WithWaitStrategy(Wait.ForUnixContainer().UntilHttpRequestIsSucceeded(request =>
request.ForPort(MilvusManagementPort).ForPath("/healthz")));
.WithWaitStrategy(Wait.ForUnixContainer().UntilContainerIsHealthy())
.WithCreateParameterModifier(parameterModifier =>
parameterModifier.Healthcheck = Healthcheck.Instance);
}

/// <inheritdoc />
Expand All @@ -92,4 +93,27 @@ protected override MilvusBuilder Merge(MilvusConfiguration oldValue, MilvusConfi
{
return new MilvusBuilder(new MilvusConfiguration(oldValue, newValue));
}

/// <summary>
/// This setup mirrors the behavior of Milvus's official configuration:
/// https://github.com/milvus-io/milvus/blob/4def0255a928287f982f1d6b8c53ed32127bb84d/scripts/standalone_embed.sh#L56-L60
/// </summary>
private sealed class Healthcheck : HealthcheckConfig
{
private Healthcheck()
{
const long ninetySeconds = 90 * 1_000_000_000L;
Test = ["CMD-SHELL", $"curl -f http://localhost:{MilvusManagementPort}/healthz"];
Interval = TimeSpan.FromSeconds(30);
Timeout = TimeSpan.FromSeconds(20);
StartPeriod = ninetySeconds;
Retries = 3;
}

/// <summary>
/// Gets the <see cref="HealthcheckConfig" /> instance.
/// </summary>
public static HealthcheckConfig Instance { get; }
= new Healthcheck();
}
}
7 changes: 2 additions & 5 deletions tests/Testcontainers.Milvus.Tests/MilvusContainerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ namespace Testcontainers.Milvus;

public abstract class MilvusContainerTest : IAsyncLifetime
{
private const string MilvusVersion = "v2.3.10";

private readonly MilvusContainer _milvusContainer;

private MilvusContainerTest(MilvusContainer milvusContainer)
Expand Down Expand Up @@ -37,7 +35,7 @@ public async Task GetVersionReturnsExpectedVersion()
.ConfigureAwait(true);

// Then
Assert.Equal(MilvusVersion, version);
Assert.EndsWith(version, MilvusBuilder.MilvusImage);
}

protected virtual ValueTask DisposeAsyncCore()
Expand All @@ -49,7 +47,7 @@ protected virtual ValueTask DisposeAsyncCore()
public sealed class MilvusDefaultConfiguration : MilvusContainerTest
{
public MilvusDefaultConfiguration()
: base(new MilvusBuilder().WithImage("milvusdb/milvus:" + MilvusVersion).Build())
: base(new MilvusBuilder().Build())
{
}
}
Expand All @@ -64,7 +62,6 @@ public MilvusSidecarConfiguration()

private MilvusSidecarConfiguration(INetwork network)
: base(new MilvusBuilder()
.WithImage("milvusdb/milvus:" + MilvusVersion)
.WithEtcdEndpoint("etcd:2379")
.DependsOn(new ContainerBuilder()
.WithImage("quay.io/coreos/etcd:v3.5.5")
Expand Down