Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project>
<PropertyGroup>
<PackageId>$(AssemblyName)</PackageId>
<Version>4.8.0</Version>
<Version>4.8.1</Version>
<AssemblyVersion>$(Version)</AssemblyVersion>
<FileVersion>$(Version)</FileVersion>
<Product>Testcontainers</Product>
Expand Down
10 changes: 9 additions & 1 deletion src/Testcontainers/Images/DockerfileArchive.cs
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,15 @@ await AddAsync(absoluteFilePath, relativeFilePath, tarOutputStream)
.ConfigureAwait(false);
}

await AddAsync(_dockerfile.FullName, _dockerfile.Name, tarOutputStream)
var dockerfileDirectoryLength = _dockerfileDirectory.FullName
.TrimEnd(Path.DirectorySeparatorChar).Length + 1;

var dockerfileRelativeFilePath = _dockerfile.FullName
.Substring(dockerfileDirectoryLength );

var dockerfileNormalizedRelativeFilePath = Unix.Instance.NormalizePath(dockerfileRelativeFilePath);

await AddAsync(_dockerfile.FullName, dockerfileNormalizedRelativeFilePath, tarOutputStream)
.ConfigureAwait(false);
}
}
Expand Down
34 changes: 34 additions & 0 deletions tests/Testcontainers.Tests/Unit/Images/ImageFromDockerfileTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,40 @@ public async Task DockerfileArchiveTar()
Assert.Equal(expected, actual);
}

[Fact]
public async Task IgnoredDockerfileIsCopiedToTarball()
{
// Given

// This test ensures Dockerfiles in subdirectories are copied to the right paths
// in the tarball, instead of ending up at the root directory:
// https://github.com/testcontainers/testcontainers-dotnet/issues/1557.
IImage image = new DockerImage("localhost/testcontainers", Guid.NewGuid().ToString("D"), string.Empty);

var actual = new SortedSet<string>();

var buildArguments = new ReadOnlyDictionary<string, string>(new Dictionary<string, string>());

var dockerfileArchive = new DockerfileArchive(null, "Assets/", "target/Dockerfile", image, buildArguments, NullLogger.Instance);

var dockerfileArchiveFilePath = await dockerfileArchive.Tar(TestContext.Current.CancellationToken)
.ConfigureAwait(true);

// When
using (var tarOut = new FileStream(dockerfileArchiveFilePath, FileMode.Open, FileAccess.Read))
{
using (var tarIn = TarArchive.CreateInputTarArchive(tarOut, Encoding.Default))
{
tarIn.ProgressMessageEvent += (_, entry, _) => actual.Add(entry.Name);
tarIn.ListContents();
}
}

// Then
Assert.Contains("target/Dockerfile", actual);
Assert.DoesNotContain("Dockerfile", actual);
}

[Fact]
public async Task ThrowsDockerfileDoesNotExist()
{
Expand Down