fix(MongoDb): Use db.runCommand({hello:1}) do detect readiness
#1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
Looks like Papercut just released a new version of their image, and it isn't compatible with the current configuration anymore. I'll check it in another PR. Luckily, they use tags now that allows us to pin the version. |
|
Tag me when changes will be ready to be tested, I'll do when I can :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The previous wait strategy indicated readiness too early when using a single-node replica set configuration.
This PR updates the wait strategy to match the approach used in other Testcontainers language implementations. Instead of relying on
db.runCommand({isMaster: 1}).ismaster, it usesdb.runCommand({hello: 1}).isWritablePrimarythough. According to the docs, this is the recommended method, since{isMaster: 1}is deprecated and has been replaced by{hello: 1}.@Yorie could you please test the changes in the PR? It would really help!
Why is it important?
-
Related issues