-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support digest in IImage
, DockerImage
and in the WithImage(string)
implementation
#1249
Merged
+33
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
reviewed
Sep 7, 2024
Kielek
force-pushed
the
digest-support
branch
from
September 9, 2024 05:21
e95e48f
to
87e6db4
Compare
Kielek
commented
Sep 9, 2024
tests/Testcontainers.Tests/Fixtures/Images/DockerImageFixture.cs
Outdated
Show resolved
Hide resolved
HofmeisterAn
changed the title
feat: Support for digest in the image definition
feat: Support digest in Sep 12, 2024
IImage
and in the DockerImage
implementation
HofmeisterAn
changed the title
feat: Support digest in
feat: Support digest in Sep 15, 2024
IImage
and in the DockerImage
implementationIImage
, DockerImage
and in the WithImage(string)
implementation
HofmeisterAn
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support for digest passed to the image parser.
Dropped workaround to fully utilize docker api and support digest in the requirements.
Why is it important?
OpenTelemetry recommend to reference all docker images by the name, tag, followed by the digest.
Part of implementing this recommendation is open-telemetry/opentelemetry-dotnet-instrumentation#3514
Passing full name to the Container API leads to
Related issues
How to test this PR
Unit tests extended.
You can check also code similar to.
Do not tested with Docker 4..13.1. The latest version is fine. The question is if the support can be dropped for 2-years old version. I think that it can be dropped as Docker for Desktop was released couple of time with security fixes. 4.13.1 should be treated as insecure and not recommended to use.
Follow-ups
Release new version. I will be happy to proceed with open-telemetry/opentelemetry-dotnet-instrumentation#3514