Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CosmosDb): SSL connection could not be established #1109

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix(CosmosDb): SSL connection could not be established #1109

merged 2 commits into from
Feb 8, 2024

Conversation

WakaToa
Copy link
Contributor

@WakaToa WakaToa commented Feb 8, 2024

What does this PR do?

Introduced the CosmosDbContainerWaitStrategy to boost the readiness check by connecting to a specific URL instead of looking for a log message. The existing wait strategy in the CosmosDbBuilder was modified to use this new strategy, thereby making the readiness check more reliable.

Why is it important?

The current readiness check is not reliable. Although the console output "Started" is logged, the container is not fully ready for use.

Related issues

Introduced the CosmosDbContainerWaitStrategy to boost the readiness check by connecting to a specific URL instead of looking for a log message. The existing wait strategy in the CosmosDbBuilder was modified to use this new strategy, thereby making the readiness check more reliable.
Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 3d9f0ce
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/65c51caeb89962000899f8d5
😎 Deploy Preview https://deploy-preview-1109--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WakaToa
Copy link
Contributor Author

WakaToa commented Feb 8, 2024

Seems like i used the wrong git config. Shouldn't be any issue. Sorry for that.

@HofmeisterAn HofmeisterAn added the bug Something isn't working label Feb 8, 2024
@HofmeisterAn HofmeisterAn changed the title Add CosmosDbContainerWaitStrategy for better readiness check fix(CosmosDb): SSL connection could not be established Feb 8, 2024
@HofmeisterAn HofmeisterAn merged commit 7f41b7a into testcontainers:develop Feb 8, 2024
9 checks passed
@HofmeisterAn
Copy link
Collaborator

Thanks for looking into this issue and creating the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants