Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Cache Docker image full and host name #1043

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

Initializes the Docker image, full and host name property lazy and once.

Why is it important?

The previous implementation delegated and created the values of the properties for each call. This PR addresses this issue and ensures that the values are created only once.

Related issues

-

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Nov 5, 2023
Copy link

netlify bot commented Nov 5, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit f5ea4ff
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6547ae549978e3000845e2d8
😎 Deploy Preview https://deploy-preview-1043--testcontainers-dotnet.netlify.app/modules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn merged commit 46c05d7 into develop Nov 5, 2023
12 checks passed
@HofmeisterAn HofmeisterAn deleted the feature/refactor-dockerimage-impl branch November 5, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant