feat: Add NATS module #1003
Merged
feat: Add NATS module #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…eption. Caused by a copy waste while doing the initial implementation.
Co-authored-by: Andre Hofmeister <[email protected]>
Fix -user & -pass were missing a -, so --user and --pass is now used. Add long params instead, e.g --jetstream instead of -js Add Validatation, if either password or username is set, then both are required. Fix EscapeDataString on username and password.
…iklasfp/testcontainers-dotnet into feat/add-nats-server-container # Conflicts: # src/Testcontainers.Nats/NatsBuilder.cs
|
@HofmeisterAn How should we handle this, you can rebase and merge if you see it fitting, or let me know what you need done from me 😄 |
Ah, perhaps I misinterpreted it. I thought you were going to make changes according to the suggestion.
I am fine with the pull request; it looks good 👍, thanks! I can merge it later today when I am back home. Rebase, etc. is not necessary. |
|
@HofmeisterAn cool!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pr adds support for the official Nats Server image
It should roughly align with the Go version providing support for
.WithUsernameand.WithPasswordThe container enables the http monitoring endpoints of Nats, and exposes the default Nats server ports:
It also adds methods for getting a Nats connection string and the url for the monitoring endpoint.
Why is it important?
I needed it for my own work, and thought I might as well share it.
And since Nats already has both Go and Node.js implementations, I guess others would benefit as well.
Related issues
N/A
How to test this PR
Tests has been added in this pr.
Run the tests in
./tests/Testcontainers.Nats.Tests