[AutoPR Microsoft.Azure.Management.Peering] some naming replacing in examples to make it inline with cli commands

.editorconfig

@@ -65,7 +65,7 @@ dotnet_naming_rule.static_fields_should_have_prefix.style = static_prefix_style
 
 dotnet_naming_symbols.static_fields.applicable_kinds = field
 dotnet_naming_symbols.static_fields.required_modifiers = static
-
+dotnet_naming_symbols.static_fields.applicable_accessibilities = private, internal, private_protected
 dotnet_naming_style.static_prefix_style.required_prefix = s_
 dotnet_naming_style.static_prefix_style.capitalization = camel_case
 
@@ -183,6 +183,3 @@ indent_size = 2
 end_of_line = lf
 [*.{cmd, bat}]
 end_of_line = crlf
-
-# Extra modifications on Corefx rule set
-dotnet_naming_symbols.static_fields.applicable_accessibilities = private, internal

.gitattributes

@@ -19,6 +19,7 @@
 
 *.htm text
 *.html text
+*.md text
 
 *.js text
 *.json text

.github/CODEOWNERS

@@ -1,5 +1,5 @@
 # Instructions for CODEOWNERS file format and automatic build failure notifications:
-# https://github.com/Azure/azure-sdk/blob/master/docs/engineering-system/codeowners.md
+# https://github.com/Azure/azure-sdk/blob/master/docs/policies/opensource.md#codeowners
 
 ###########
 # SDK
@@ -14,7 +14,7 @@
 # Service teams
 /sdk/appconfiguration/ @annelo-msft
 
-/sdk/batch/ @xingwu1 @matthchr @bgklein
+/sdk/batch/ @matthchr 
 
 /sdk/cognitiveservices/language.textanalytics/ @assafi 
 /sdk/cognitiveservices/vision.computervision/ @toothache
@@ -31,7 +31,7 @@
 
 /sdk/search/ @brjohnstmsft
 /sdk/servicebus/ @nemakam @jsquire
-/sdk/storage/ @seanmcc-msft @amnguye @tg-msft
+/sdk/storage/ @seanmcc-msft @amnguye @tg-msft @JoshLove-msft
 # Management Plane
 /**/*Management*/ @erich-wang
 

eng/.docsettings.yml

@@ -54,6 +54,7 @@ known_presence_issues:
   - ['sdk/batch/Microsoft.Azure.Batch.FileStaging','#5499']
   - ['sdk/graphrbac/Microsoft.Azure.Graph.RBAC','#5499']
   - ['sdk/search','#5499']
+  - ['sdk/cognitiveservices/InkRecognizer','#5499']
 
 known_content_issues:
   - ['README.md','Root readme']

eng/CodeAnalysis.ruleset

@@ -190,7 +190,7 @@
         <Rule Id="SA1626"  Action="None" />          <!-- Single-line comments should not use documentation style slashes -->
         <Rule Id="SA1627"  Action="None" />          <!-- Documentation text should not be empty -->
         <Rule Id="SA1628"  Action="None" />          <!-- Documentation text should begin with a capital letter -->
-        <Rule Id="SA1629"  Action="None" />          <!-- Documentation text should end with a period -->
+        <Rule Id="SA1629"  Action="Info" />          <!-- Documentation text should end with a period -->
         <Rule Id="SA1630"  Action="None" />          <!-- Documentation text should contain whitespace -->
         <Rule Id="SA1631"  Action="None" />          <!-- Documentation should meet character percentage -->
         <Rule Id="SA1632"  Action="None" />          <!-- Documentation text should meet minimum character length -->

eng/Packages.Data.props

@@ -9,10 +9,10 @@
   <ItemGroup>
     <PackageReference Update="ApprovalTests" Version="3.0.22" />
     <PackageReference Update="ApprovalUtilities" Version="3.0.22" />
-    <PackageReference Update="Azure.Core" Version="1.0.0-preview.8" />
-    <PackageReference Update="Azure.Identity" Version="1.0.0-preview.4" />
-    <PackageReference Update="Azure.Messaging.EventHubs" Version="5.0.0-preview.3" />
-    <PackageReference Update="Azure.Storage.Blobs" Version="12.0.0-preview.3" />
+    <PackageReference Update="Azure.Core" Version="1.0.0-preview.9" />
+    <PackageReference Update="Azure.Identity" Version="1.0.0-preview.5" />
+    <PackageReference Update="Azure.Messaging.EventHubs" Version="5.0.0-preview.4" />
+    <PackageReference Update="Azure.Storage.Blobs" Version="12.0.0-preview.4" />
     <PackageReference Update="BenchmarkDotNet" Version="0.11.5" />
     <PackageReference Update="FsCheck.Xunit" Version="2.14.0" />
     <PackageReference Update="Microsoft.AspNetCore.Server.Kestrel" Version="2.2.0" />
@@ -105,13 +105,13 @@
   <ItemGroup Condition="'$(IsClientLibrary)' == 'true'">
     <PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20190716.1" />
     <PackageReference Update="System.Memory" Version="4.5.3" />
-    <PackageReference Update="Microsoft.Bcl.AsyncInterfaces" Version="1.0.0-rc1.19456.4" />
+    <PackageReference Update="Microsoft.Bcl.AsyncInterfaces" Version="1.0.0" />
     <PackageReference Update="Microsoft.Extensions.DependencyInjection.Abstractions" Version="2.1.0" />
     <PackageReference Update="Microsoft.Extensions.DependencyInjection" Version="2.1.0" />
     <PackageReference Update="Microsoft.Extensions.Logging.Abstractions" Version="2.1.0" />
     <PackageReference Update="Microsoft.Extensions.Options" Version="2.1.0" />
-    <PackageReference Update="System.Threading.Channels" Version="4.6.0-rc1.19456.4" />
-    <PackageReference Update="System.Text.Json" Version="4.6.0-rc1.19456.4" />
-    <PackageReference Update="System.Diagnostics.DiagnosticSource" Version="4.6.0-rc1.19456.4" />
+    <PackageReference Update="System.Threading.Channels" Version="4.6.0" />
+    <PackageReference Update="System.Text.Json" Version="4.6.0" />
+    <PackageReference Update="System.Diagnostics.DiagnosticSource" Version="4.6.0" />
   </ItemGroup>
 </Project>

eng/SnippetGenerator/MarkdownProcessor.cs

@@ -0,0 +1,29 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System;
+using System.Text.RegularExpressions;
+
+namespace SnippetGenerator
+{
+    public class MarkdownProcessor
+    {
+        private static readonly string _snippetFormat = "```C# {0}{1}{2}```";
+        private static Regex _snippetRegex = new Regex("```\\s*?C#[ ]*?(?<name>[\\w:]+).*?```",
+            RegexOptions.Compiled | RegexOptions.Multiline | RegexOptions.Singleline | RegexOptions.IgnoreCase);
+
+        public static string Process(string markdown, Func<string, string> snippetProvider)
+        {
+            return _snippetRegex.Replace(markdown, match =>
+            {
+                var matchGroup = match.Groups["name"];
+                if (matchGroup.Success)
+                {
+                    return string.Format(_snippetFormat, matchGroup.Value, Environment.NewLine, snippetProvider(matchGroup.Value));
+                }
+
+                return match.Value;
+            });
+        }
+    }
+}

eng/SnippetGenerator/Program.cs

@@ -0,0 +1,166 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using McMaster.Extensions.CommandLineUtils;
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.CSharp;
+using Microsoft.CodeAnalysis.CSharp.Syntax;
+using Microsoft.CodeAnalysis.Text;
+
+namespace SnippetGenerator
+{
+    public class Program
+    {
+        [Option(ShortName = "u")]
+        public string Markdown { get; set; }
+
+        [Option(ShortName = "s")]
+        public string Snippets { get; set; }
+
+        public static int Main(string[] args)
+        {
+            return CommandLineApplication.Execute<Program>(args);
+        }
+
+        public async Task OnExecuteAsync()
+        {
+            Console.WriteLine($"Processing {Markdown}");
+
+            var text = File.ReadAllText(Markdown);
+            var snippets = await GetSnippetsInDirectory(Snippets);
+            Console.WriteLine($"Discovered snippets:");
+
+            foreach (var snippet in snippets)
+            {
+                Console.WriteLine($" {snippet.Name}");
+            }
+
+            text = MarkdownProcessor.Process(text, s => {
+                var selectedSnippets = snippets.Where(snip => snip.Name == s).ToArray();
+                if (selectedSnippets.Length > 1)
+                {
+                    throw new InvalidOperationException($"Multiple snippets with the name '{s}' defined '{Snippets}'");
+                }
+                if (selectedSnippets.Length == 0)
+                {
+                    throw new InvalidOperationException($"Snippet '{s}' not found in directory '{Snippets}'");
+                }
+
+                var selectedSnippet = selectedSnippets.Single();
+                Console.WriteLine($"Replaced {selectedSnippet.Name}");
+                return FormatSnippet(selectedSnippet.Text);
+            });
+
+            File.WriteAllText(Markdown, text);
+        }
+
+        private string FormatSnippet(SourceText text)
+        {
+            int minIndent = int.MaxValue;
+            int firstLine = 0;
+            var lines = text.Lines.Select(l => l.ToString()).ToArray();
+
+            int lastLine = lines.Length - 1;
+
+            while (string.IsNullOrWhiteSpace(lines[firstLine]))
+            {
+                firstLine++;
+            }
+
+            while (string.IsNullOrWhiteSpace(lines[lastLine]))
+            {
+                lastLine--;
+            }
+
+            for (var index = firstLine; index <= lastLine; index++)
+            {
+                var textLine = lines[index];
+
+                if (string.IsNullOrWhiteSpace(textLine))
+                {
+                    continue;
+                }
+
+                int i;
+                for (i = 0; i < textLine.Length; i++)
+                {
+                    if (!char.IsWhiteSpace(textLine[i])) break;
+                }
+
+                minIndent = Math.Min(minIndent, i);
+            }
+
+            var stringBuilder = new StringBuilder();
+            for (var index = firstLine; index  <= lastLine; index++)
+            {
+                var line = lines[index];
+                line = string.IsNullOrWhiteSpace(line) ? string.Empty : line.Substring(minIndent);
+                stringBuilder.AppendLine(line);
+            }
+
+            return stringBuilder.ToString();
+        }
+
+        private async Task<List<Snippet>> GetSnippetsInDirectory(string baseDirectory)
+        {
+            var list = new List<Snippet>();
+            foreach (var file in Directory.GetFiles(baseDirectory, "*.cs", SearchOption.AllDirectories))
+            {
+                var syntaxTree = CSharpSyntaxTree.ParseText(
+                    File.ReadAllText(file),
+                    new CSharpParseOptions(LanguageVersion.Preview),
+                    path: file);
+                list.AddRange(await GetAllSnippetsAsync(syntaxTree));
+            }
+
+            return list;
+        }
+
+        private async Task<Snippet[]> GetAllSnippetsAsync(SyntaxTree syntaxTree)
+        {
+            var snippets = new List<Snippet>();
+            var directiveWalker = new DirectiveWalker();
+            directiveWalker.Visit(await syntaxTree.GetRootAsync());
+
+            foreach (var region in directiveWalker.Regions)
+            {
+                var syntaxTrivia = region.Item1.EndOfDirectiveToken.LeadingTrivia.First(t => t.IsKind(SyntaxKind.PreprocessingMessageTrivia));
+                var fromBounds = TextSpan.FromBounds(
+                    region.Item1.GetLocation().SourceSpan.End,
+                    region.Item2.GetLocation().SourceSpan.Start);
+
+                snippets.Add(new Snippet(syntaxTrivia.ToString(), syntaxTree.GetText().GetSubText(fromBounds)));
+            }
+
+            return snippets.ToArray();
+        }
+
+        class DirectiveWalker : CSharpSyntaxWalker
+        {
+            private Stack<RegionDirectiveTriviaSyntax> _regions = new Stack<RegionDirectiveTriviaSyntax>();
+            public List<(RegionDirectiveTriviaSyntax, EndRegionDirectiveTriviaSyntax)> Regions { get; } = new List<(RegionDirectiveTriviaSyntax, EndRegionDirectiveTriviaSyntax)>();
+
+            public DirectiveWalker() : base(SyntaxWalkerDepth.StructuredTrivia)
+            {
+            }
+
+            public override void VisitRegionDirectiveTrivia(RegionDirectiveTriviaSyntax node)
+            {
+                base.VisitRegionDirectiveTrivia(node);
+                _regions.Push(node);
+            }
+
+            public override void VisitEndRegionDirectiveTrivia(EndRegionDirectiveTriviaSyntax node)
+            {
+                base.VisitEndRegionDirectiveTrivia(node);
+                Regions.Add((_regions.Pop(), node));
+            }
+        }
+    }
+}

eng/SnippetGenerator/Snippet.cs

@@ -0,0 +1,19 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using Microsoft.CodeAnalysis.Text;
+
+namespace SnippetGenerator
+{
+    internal class Snippet
+    {
+        public string Name { get; }
+        public SourceText Text { get; }
+
+        public Snippet(string name, SourceText text)
+        {
+            Name = name;
+            Text = text;
+        }
+    }
+}

eng/SnippetGenerator/SnippetGenerator.csproj

@@ -0,0 +1,17 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>netcoreapp2.1</TargetFramework>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="McMaster.Extensions.CommandLineUtils" Version="2.3.4" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.2.1" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.2.1" />
+    <PackageReference Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="3.2.1" />
+    <PackageReference Include="Microsoft.Build" Version="16.0.461" />
+    <PackageReference Include="Microsoft.Build.Tasks.Core" Version="16.0.461" />
+  </ItemGroup>
+
+</Project>

eng/SnippetGenerator/SnippetGenerator.sln

@@ -0,0 +1,25 @@
+
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio Version 16
+VisualStudioVersion = 16.0.29315.20
+MinimumVisualStudioVersion = 10.0.40219.1
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SnippetGenerator", "SnippetGenerator.csproj", "{DC46BB54-17A2-471C-A21A-D7F329505955}"
+EndProject
+Global
+	GlobalSection(SolutionConfigurationPlatforms) = preSolution
+		Debug|Any CPU = Debug|Any CPU
+		Release|Any CPU = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(ProjectConfigurationPlatforms) = postSolution
+		{DC46BB54-17A2-471C-A21A-D7F329505955}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{DC46BB54-17A2-471C-A21A-D7F329505955}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{DC46BB54-17A2-471C-A21A-D7F329505955}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{DC46BB54-17A2-471C-A21A-D7F329505955}.Release|Any CPU.Build.0 = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(SolutionProperties) = preSolution
+		HideSolutionNode = FALSE
+	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {8162DAAE-F789-44E8-8552-58A3581A0AF3}
+	EndGlobalSection
+EndGlobal

eng/Update-Snippets.ps1

@@ -0,0 +1,11 @@
+$generatorProject = "$PSScriptRoot\SnippetGenerator\SnippetGenerator.csproj";
+dotnet build $generatorProject
+
+foreach ($file in Get-ChildItem "$PSScriptRoot\..\sdk" -Filter README.md -Recurse)
+{
+    $samples = Join-Path $file.Directory "samples"
+    if (Test-Path $samples)
+    {
+        dotnet run -p $generatorProject --no-build -u $file.FullName -s $samples
+    }
+}

eng/mgmt/mgmtmetadata/azure-kusto_resource-manager.txt

@@ -3,12 +3,12 @@ AutoRest installed successfully.
 Commencing code generation
 Generating CSharp code
 Executing AutoRest command
-cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/master/specification/azure-kusto/resource-manager/readme.md --csharp --version=latest --reflect-api-versions --csharp-sdks-folder=C:\Git\Clients\azure-sdk-for-net\src\SDKs
-2019-09-02 13:37:08 UTC
+cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/master/specification/azure-kusto/resource-manager/readme.md --csharp --version=latest --reflect-api-versions --csharp-sdks-folder=C:\repos\azure-sdk-for-net\sdk
+2019-10-10 18:05:55 UTC
 Azure-rest-api-specs repository information
 GitHub fork: Azure
 Branch:      master
-Commit:      8fff657a61cd85b0a9ce9a42d17dc4f536d9f7a8
+Commit:      1dec7ad95de2a996e02f119eaa1f00e49e45cb3a
 AutoRest information
 Requested version: latest
 Bootstrapper version:    autorest@2.0.4283