This repository was archived by the owner on Aug 26, 2025. It is now read-only.
[AutoPR sql/resource-manager/v2014_04_01] Change AdministratorName parameter, it should take constant value defined in enum #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Roll back customizations to ci.yml for cosmos. * Created a special stage template for cosmos. * Tweaked template path. * Added globals reference in tests job.
* Removed azure-core-http-netty from the published artifact list. * Actually remove the artifact.
This PR includes the requirement of Javadoc annotation @codesnippet @code, check: Use {@codesnippet ...} instead of '<code>', '<pre>', or '{@code ...}' if these tags span multiple lines. Inline code samples are fine as-is. @codesnippet description should match naming pattern requirement below: Package, class and method names should be concatenated by dot '.'. Ex., packageName.className.methodName Methods arguments should be concatenated by dash '-'. Ex. string-string for methodName(String s, String s2) Use '#' to concatenate 1) and 2), ex packageName.className.methodName#string-string. Fixed and Suppress checkstyle errors : A minor fix for HttpPipeLinePolicyCheck, which to find a correct package name. Fixed all non-critical errors but suppress those critical errors so code owner can fix them when they are available.
Good Logging Practice
1) ClientLogger in public API should all named 'logger', public API classes are those classes that are declared
as public and that do not exist in an implementation package or subpackage.
2) ClientLogger should be non-static instance logger
3) Should not use any external logger class, only use ClientLogger. No slf4j, log4j, or other logging imports are allowed.
'System.out' and 'System.err' is not allowed as well.
4) All classes should use ClientLogger as logger only but except ClientLogger itself
* Remove Storage swagger files and reference azure-rest-api-specs Also includes a few changes to Queues that were there before switching swagger references (it may not have been regenerated in awhile?). * Removing last swagger file from repo, fixing tests to comply with new swagger generation * Added comment to get StorageErrorCode into the Swagger
Fluent Methods: All methods that return an instance of the class, and that have one parameter. The method name should not start with any word in the list of avoidStartWords. All methods should not be declared to throws any checked exceptions.
KV track 1 bug fix + pom updates
* use expected artifact names * remove -complete artifact from kv unified pipeline * remove -test from keyvault artifact specification (it does not output all currently expected artifacts)
…4712) Batch 2 Rule # 5 Service client methods: All methods that are in a class annotated with @ServiceClient, where the method has a @ServiceMethod annotation, should follow these rules: Methods names should follow a common vocabulary. Refer to Java spec for this naming pattern https://azure.github.io/azure-sdk/java_design.html. Method names imply certain rules around expected return type - these should all be validated. Methods should not have 'Async' added to their method name. Return types of async and sync clients should be as per guidelines: [this check will be ignored for now since I am still struggling on how to get the Reflection working in the code-quality-check] Return type for async collection should be of type ? extends PagedFlux Return type for async single value should be of type ? extends Mono Return type for sync collection should be of type ? extends PagedIterable Return type for sync single value should be of type ? extends Response Rule # 10 'withResponse' naming pattern: All methods annotated with @ServiceMethod that return a Response (or Mono) must have their method name end with 'withResponse'. If the service method does not return a Response or Mono, it must not end with 'withResponse'. Batch 3 Rule # 1 Context in all the right places: Context should be passed in as an argument to all public methods annotated with @ServiceMethod that return Response in sync clients. Only in the sync case: E.g. we want this: Public Response getFooWithResponse(int x, int y, Context c) In the async case, we should check to ensure we have no service methods that take Context! Rule # 6 Async client should have async = true property set in @ServiceClient annotation To validate this, if the class has @ServiceClient annotation and if the classname AsyncClient, verify that the async property of @ServiceClient annotation is set to true. Similarly, if the class has @ServiceClient annotation and if the classname is Client, verify that the async property of @ServiceClient annotation is set to false Change class Context to be final
…5154) * Adding java automatic module names to all track two client libraries. Removing a few unused dependencies. Enforcing a Maven baseline of 3.6.1 to tighten our tooling scope.
* This introduces a builder API for creating a NettyAsyncHttpClient instance. The next step would be to provide API in the client libraries to accept an HttpClient instance, so that people may customise their HTTP clients.
* Kusto: generate package v2019_05_15 * Fix build errors for kusto.
Added File and Queue SAS functionality for Storage
* Updating clients to use CREATE_NEW for downloadToFile methods * Unit tests and playback records * Fixing unit test and resource cleanup
* remove java code isImple check but move to suppression and add only check for public class for external Dependency check * change deque to LIFO queue
* Updating testing environment variables to match what is used * Turn on live tests for AppConfiguration and forcing tests to fail at end of module * Update tests.yml * Update tests.yml * Update globals.yml * Update archetype-sdk-tests.yml
* Creating a base type of PagedFlux, to allow other types to be created in cases where a subclass of PagedResponse is used.
… And Queues (#5155) Adds exception processing to map `StorageErrorException` to `StorageException` in Files and Queues.
* Added service principle for storage user delegate key
* OkHttp plugin for azure-core * adding tests for okhttp plugin * Invoking enqueue from subscribe. Making builder reusable and enable using existing OkHttpClient as base * Reflecting removal of HttpClient configiguration methods in OkHttp plugin * Removing redundant parantheses. Better java doc for builder::interceptors(List)
* remove java code isImple check but move to suppression and add only check for public class for external Dependency check * suppress one that not RuntimeException and fixes rest of errors
* Fixing high CPU and memory leak in session pump caused by timed out accept session requests. * Fixing a minor race condition when closing sender or receiver on link creation timeout. * Fixing 2 nit review comments.
…oxy. Instead of teating proxy as the peer, treat the endpoing host as the peer. (#5467)
* update version * parent pom changed since last time so stay with 3.1.0
* Update cosmos versions; up the minor build. * Hot fix version should be 3.2.1 * update versions to the next build number * Remove snapshot from the version
…5566) * Move implementation models to implementation.models for storage-file * Merged in master * Add back custom deserializer * Add back package-info * Fix samples and test imports * Fixing a few more imports * Open implementation.models to Jackson databind and Azure Core * Move StorageError back to models * Move another class into models * Cleanup pom * Fix pom change * Suppress SpotBugs issue in codegen model
* Move internal model types to implementation * Move more annotations out of implementation * Move GeoReplication to models (recursively) * Also enums * Regenerate * add missing package-info * Move implementation models to implementation.models * Updated pom and module-info
* Fix errors caused by upgrading to latest reactor versions * Update netty version to fix failures on linux * Use Netty as default HTTP client * Update README
Core Cryptography API
* Update return type for download API * Remove unused method * Fix unit test
Author
Installation InstructionsYou can install the package Direct DownloadThe generated package artifacts can be directly downloaded from here: |
* Add trackLastEnqueuedEventInformation. * Integrate EventHubConsumerOptions.trackLastEnqueuedInformation into creating consumer. * Update to EventHubConsumerOptions.trackLastEnqueuedEventProperties * Update EventHubConsumer.LastEnqueuedEventProperties as each event is received. * Add tests. * Make LastEnqueuedEventProperties immutable. * Use AtomicReference in EventHubAsyncConsumer. * Throw exception if EventPosition.enqueuedDateTime could not be parsed. * Fixing log information in EventHubAsyncProducer.
…d download to file methods (#5631)
cosmos needs to use some built-in windows powershell cmdlets to work with certificates so we cannot use the cross-plat pwsh because that one doesn't support the windows specific cmdlets.
* Removed Metadata class in favor of Map * Cleanup unit tests * Fixed Metadata unit tests * Fix additional unit tests and typo * Changes to fix pipeline issues * More unit test and linting fixes * Fix for Mockito mocking
* add certificates spec to ci yml * emulator update
openapi-sdkautomation
bot
force-pushed
the
sdkAutomation/sql/resource-manager/v2014_04_01@7377
branch
from
e18ae89 to
8d1f2ce
Compare
Merge branch 'master' into changeJsonForADAdminoOnMI
openapi-sdkautomation
bot
force-pushed
the
sdkAutomation/sql/resource-manager/v2014_04_01@7377
branch
from
8d1f2ce to
6782aa4
Compare
PhoenixHe-NV
deleted the
sdkAutomation/sql/resource-manager/v2014_04_01@7377
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to sync Azure/azure-rest-api-specs#7377