Skip to content
This repository was archived by the owner on Aug 26, 2025. It is now read-only.

[AutoPR servicebus/resource-manager/v2015_08_01] ServiceBus: added NetworkRuleSets list API#272

Closed
openapi-sdkautomation[bot] wants to merge 113 commits intotest-repo-billy:sdkAutomation/servicebus/resource-manager/v2015_08_01from
AzureSDKAutomation:sdkAutomation/servicebus/resource-manager/v2015_08_01@7050
Closed

[AutoPR servicebus/resource-manager/v2015_08_01] ServiceBus: added NetworkRuleSets list API#272
openapi-sdkautomation[bot] wants to merge 113 commits intotest-repo-billy:sdkAutomation/servicebus/resource-manager/v2015_08_01from
AzureSDKAutomation:sdkAutomation/servicebus/resource-manager/v2015_08_01@7050

Conversation

@openapi-sdkautomation
Copy link

conniey and others added 30 commits August 6, 2019 20:39
* Fixing link to storage and event hubs.

* Fix broken links to Event Hubs. Convert tabs to spaces.

* Use relative links to source code. Remove en-us from docs.microsoft.com URLs.

* Remove en-us from identity/README.md
Cosmos Key Credential holds the key credentials, and supports key rotations. User can update the key in CosmosKeyCredential object, and that will be reflected in SDK on the fly.
* New version changes - 3.1.0

* Fixed Hello World Demo Link
* Add Samples section. Remove en-us from links.

* Remove en-us.

* Fix samples links in storage.

* Move samples to correct location.

* Fix broken links in README. Correct formatting.

* remove [package] from README because none of the others have it.

* Add syntax highlighting alias java to snippets.

* Undo * in appconfig

* Update shared key credential steps.

* Updating README with comments.
* Sync Client API - Replace Iterable with PagedIterable.
* Bump versions after preview 2

* Update versions in spotbugs

* reference preview 4 for core in spotbugs

* SDK_VERSION in key vault config

* Update versions in jacoco
* Add custom validation for Immutable notation to allow only final fields

* fixes for all classes with notation immutable to follow checkstyle rule
* Fix spotbugs pipeline for PR builds
* Azure Storage Common and updates to Azure Storage Blobs to use it

* Fixed parent POM version in Common package, cleaned up linting issues

* Updated CI build file

* Add azure-storage-common to pom.service.xml

* Fixed formatting
* Auto-gen and record tests

* Update version

* Recordings were written to wrong directory, moving them

* Retrigger CI
* Azure Storage Common and updates to Azure Storage Blobs to use it

* Fixed parent POM version in Common package, cleaned up linting issues

* Updated CI build file

* Add azure-storage-common to pom.service.xml

* Files and Queues using Common package
* Added logWarningAndThrow and changes logAndThrow to logErrorAndThrow and have them return the throwable

* Updated other uses of logAndThrow

* Changed method name and input to Exception

* Reverted back to runtime exception due to type erasure issue causing SpotBug errors

* Removed commented out SpotBugs exclusion
Update KV READMEs
* Rename EventHubConsumer -> EventHubAsyncConsumer.

* Rename javadoc code snippets from EventHubClientBuild -> EventHubAsyncClient.

* Rename EventHubConsumer samples -> EventHubAsyncConsumer.

* Rename EventHubProducer samples -> EventHubAsyncProducer.

* Rename EventHubProducer -> EventHubAsyncProducer.

* Inline variable for EventPosition.
* Remove intermediate POM.

* Fix artifact name.

* Update module reference.
* Change to the new Logging API
* remove java code isImple check but move to suppression and add only check for public class for external Dependency check

* init

* updates HttpPipelinePolicy check

* rewording and rearranges

* regular expression for simplicity of suppresion for track 1
mitchdenny and others added 22 commits August 26, 2019 12:01
* Setup sdk/loganalytics for unified pipelines.

* Provided staging profile.

* Tweaked artifact name.
* Setup event grid for unified pipelines.

* Added staging profile and tweaked artifact name.:
* Setup mediaservices for unified pipelines.

* Added staging profile.
* Setup AI for unified pipelines.

* Added staging profile and updated artifact names.
* Setup unified pipelines for sdk/cognitiveservices

* Updated staging profiles and artifact names.
* Added storage to the aggregate reports

* Fixing SpotBug issues

* One last SpotBug fix

* Fixed invalid use in sample
* Added clearRange and remove the FileRangeWriteType
* Fixed bytebuffer issue.
* add more eng entries to CODEOWNERS with use the correct owners
* Basic plumbing for pipeline caching.

* Using new key format.

* Add caching to build and analyze phases.

* Narrowing scope of fingerprint.

* Removed caching from analyze step.

* Adding caching kill switch.
Commit directly to master to test a change (need to simulate a CI trigger).
* Roll back customizations to ci.yml for cosmos.

* Created a special stage template for cosmos.

* Tweaked template path.

* Added globals reference in tests job.
* Removed azure-core-http-netty from the published artifact list.

* Actually remove the artifact.
This PR includes the requirement of Javadoc annotation @codesnippet @code, check:

Use {@codesnippet ...} instead of '<code>', '<pre>', or '{@code ...}' if these tags span multiple lines. Inline code samples are fine as-is.
@codesnippet description should match naming pattern requirement below:

Package, class and method names should be concatenated by dot '.'. Ex., packageName.className.methodName
Methods arguments should be concatenated by dash '-'. Ex. string-string for methodName(String s, String s2)
Use '#' to concatenate 1) and 2), ex packageName.className.methodName#string-string.
Fixed and Suppress checkstyle errors :

A minor fix for HttpPipeLinePolicyCheck, which to find a correct package name.
Fixed all non-critical errors but suppress those critical errors so code owner can fix them when they are available.
Good Logging Practice
    1) ClientLogger in public API should all named 'logger', public API classes are those classes that are declared
       as public and that do not exist in an implementation package or subpackage.
    2) ClientLogger should be non-static instance logger
    3) Should not use any external logger class, only use ClientLogger. No slf4j, log4j, or other logging imports are allowed.
      'System.out' and 'System.err' is not allowed as well.
    4) All classes should use ClientLogger as logger only but except ClientLogger itself
@openapi-sdkautomation
Copy link
Author

Installation Instructions

You can install the package servicebus/resource-manager/v2015_08_01 of this PR by downloading the artifact jar files. Then ensure that the jar files are on your project's classpath.

Direct Download

The generated package artifacts can be directly downloaded from here:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.