Skip to content
This repository was archived by the owner on Aug 26, 2025. It is now read-only.

Conversation

@msyyc
Copy link

@msyyc msyyc commented Aug 7, 2024

No description provided.

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Aug 7, 2024

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

@openapi-pipeline-app-test
Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

@raych1 raych1 merged commit 0bc7c1e into main Aug 7, 2024
@msyyc msyyc deleted the msyyc-patch-2 branch August 7, 2024 10:02
chunyu3 pushed a commit that referenced this pull request Oct 28, 2024
* test breaking change mlc in js (#3451)

* `

* `

* Revert "`"

This reverts commit c26fc6a.

* Update specificationRepositoryConfiguration.json (#3457)

* Update specificationRepositoryConfiguration.json (#3459)

* Update specificationRepositoryConfiguration.json (#3462)

Revert python repo branch change as it was deleted.

* Update specificationRepositoryConfiguration.json (#3463)

* Migrate typespec-validation.yml to GH Actions

* path, fetch depth

* Introduce error

* Test a feature that AI says will collapse logs (doubtful it'll work)

* Revert "Test a feature that AI says will collapse logs (doubtful it'll work)"

This reverts commit 04aed83.

* Log $LASTEXITCODE

* Invalid syntax

* Use error logging, remove continue-on-error because that is different behavior in GitHub Actions compared to ignoreLASTEXITCODE

* Errors also get annotations in GitHub Actions

* String replacement

* Revert Logging-Functions.ps1

* Test composite action

* File location

* Invocation

* Add typespec-validation-all.yml

* Migrate typespec-validation-all.yml

* Revert main.tsp invalid spec

* fetch-depth: 2

* Long paths

* checkout@v4

* Remove pipelines

* *.yml -> *.yaml

* Do not change specificationRepositoryConfiguration.json

* Job names (for checks)

* Add Skip/Take logic and matrix

* Syntax

* Rename

* Remove "shell"

* Try defaults.run.shell (unlikely to work)

* bash

* Name for actions/setup-node@v4 does not appear in the logs. Remove.

* Use sharding semantics

* Shard

* Review feedback

* Review feedback

* +1

* Revert "Shard"... Display is confusing because it starts at 0 and doesn't reach total-shards. Math is not allowed in expressions.

This reverts commit 035bec73044d60c07307fd6efc19b7295258a507.

* Shard only if TotalShards > 0

* Remove description (schema validaiton does not pass, let's see what GH Actions says)

* The `description` property is not absolutely required by GH Actions at this time but adding back in because schema requires it.

* Add array functions and tests

* Move Copy-ApiVersion.Tests.ps1 out of folder (adjust paths so they are accurate)

* Add trailing newline

* Add trailing newline

* Update .github/workflows/typespec-validation.yaml

Co-authored-by: Mike Harder <[email protected]>

* Review feedback

* Update eng/scripts/TypeSpec-Validation.ps1

Co-authored-by: Mike Harder <[email protected]>

---------

Co-authored-by: Wanpeng Li <[email protected]>
Co-authored-by: Peng Jiahui <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants