[DO NOT MERGE][Internal testing] test ARM spec change - Test 2 by konrad-jamrozik · Pull Request #2934 · test-repo-billy/azure-rest-api-specs

konrad-jamrozik · 2023-06-20T23:52:45Z

This is a PR made by the Azure SDK Engineering System team.

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
I commit to follow the Breaking Change Policy.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

openapi-pipeline-app-test · 2023-06-20T23:52:49Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
changes.json	2023-07-01-preview(b08c4bc)	2023-07-01-preview(main)

Rule	Message
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. New: Microsoft.Resources/preview/2023-07-01-preview/changes.json#L303:9 Old: Microsoft.Resources/preview/2023-07-01-preview/changes.json#L303:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.3)	new version	base version
package-changes-2023-07-01-preview	package-changes-2023-07-01-preview(b08c4bc)	package-changes-2023-07-01-preview(main)

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Resources/preview/2023-07-01-preview/changes.json#L49
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/preview/2023-07-01-preview/changes.json#L49
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Resources/preview/2023-07-01-preview/changes.json#L49
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Resources/preview/2023-07-01-preview/changes.json#L106
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/preview/2023-07-01-preview/changes.json#L106
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Resources/preview/2023-07-01-preview/changes.json#L106
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Resources/preview/2023-07-01-preview/changes.json#L261

️️✔️~[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️~[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️~[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

_{Posted by Swagger Pipeline | How to fix these errors?}

workflow-bot-test · 2023-06-20T23:52:49Z

Hi, @konrad-jamrozik Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app-test · 2023-06-20T23:52:50Z

Swagger Generation Artifacts

️🔄~[Staging] ApiDocPreview inProgress [Detail]

️⚠️ azure-sdk-for-net-track2 warning [Detail]

⚠️Warning [Logs] Generate from fc1101b00fd40d3c914f7599b5c99cefc8d68178. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️Azure.ResourceManager.Resources [View full logs]
- Azure.ResourceManager.Resources.1.7.0-alpha.20230621.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from fc1101b00fd40d3c914f7599b5c99cefc8d68178. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-resource [View full logs] [Preview SDK Changes] Breaking Change Detected
- azure-mgmt-resource-23.1.0b1.zip
- azure_mgmt_resource-23.1.0b1-py3-none-any.whl
```
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Parameter mode of model DenySettings is now required
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from fc1101b00fd40d3c914f7599b5c99cefc8d68178. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-resources-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from fc1101b00fd40d3c914f7599b5c99cefc8d68178. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/resources/armresources [View full logs] [Preview SDK Changes] Breaking Change Detected

Only show 12 items here, please refer to log for details.

info	[Changelog] - Type of `DeploymentWhatIfProperties.Parameters` has been changed from `any` to `map[string]*DeploymentParameter`
info	[Changelog] - Operation `*TagsClient.CreateOrUpdateAtScope` has been changed to LRO, use `*TagsClient.BeginCreateOrUpdateAtScope` instead.
info	[Changelog] - Operation `*TagsClient.DeleteAtScope` has been changed to LRO, use `*TagsClient.BeginDeleteAtScope` instead.
info	[Changelog] - Operation `*TagsClient.UpdateAtScope` has been changed to LRO, use `*TagsClient.BeginUpdateAtScope` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `DeploymentParameter`
info	[Changelog] - New struct `KeyVaultParameterReference`
info	[Changelog] - New struct `KeyVaultReference`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).

️✔️sdk/resourcemanager/resources/armdeploymentscripts [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armfeatures [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armlinks [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armlocks [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armmanagedapplications [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armpolicy [View full logs] [Preview SDK Changes]

Only show 12 items here, please refer to log for details.

info	[Changelog] - New struct `VariableColumn`
info	[Changelog] - New struct `VariableListResult`
info	[Changelog] - New struct `VariableProperties`
info	[Changelog] - New struct `VariableValue`
info	[Changelog] - New struct `VariableValueColumnValue`
info	[Changelog] - New struct `VariableValueListResult`
info	[Changelog] - New struct `VariableValueProperties`
info	[Changelog] - New field `Overrides`, `ResourceSelectors` in struct `AssignmentProperties`
info	[Changelog] - New field `Properties` in struct `AssignmentUpdate`
info	[Changelog] - New field `AssignmentScopeValidation`, `ResourceSelectors` in struct `ExemptionProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 62 additive change(s).

️✔️sdk/resourcemanager/resources/armsubscriptions [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armtemplatespecs [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/resources/armchanges [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from fc1101b00fd40d3c914f7599b5c99cefc8d68178. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.

️✔️@azure/arm-changes [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-changes-2.0.0.tgz

info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface ChangesListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ChangesListNextOptionalParams no longer has parameter top

️✔️@azure/arm-features [View full logs] [Preview SDK Changes] Breaking Change Detected
- azure-arm-features-4.0.0.tgz
```
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Class FeatureClient has a new signature
```

️✔️@azure/arm-links [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-links-3.0.0.tgz

info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Class ManagementLinkClient has a new signature
info	[Changelog]   - Interface ResourceLinksListAtSubscriptionNextOptionalParams no longer has parameter filter

️✔️@azure/arm-locks [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-locks-3.0.0.tgz

info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Class ManagementLockClient has a new signature
info	[Changelog]   - Interface ManagementLocksListAtResourceGroupLevelNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface ManagementLocksListAtResourceLevelNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface ManagementLocksListAtSubscriptionLevelNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface ManagementLocksListByScopeNextOptionalParams no longer has parameter filter

️✔️@azure/arm-managedapplications [View full logs] [Preview SDK Changes] Breaking Change Detected
- azure-arm-managedapplications-3.0.0.tgz
```
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Class ApplicationClient has a new signature
```

️✔️@azure/arm-policy [View full logs] [Preview SDK Changes]

azure-arm-policy-5.2.0-beta.1.tgz

Only show 14 items here, please refer to log for details.

info	[Changelog]   - Added Type Alias VariableValuesGetResponse
info	[Changelog]   - Added Type Alias VariableValuesListForManagementGroupNextResponse
info	[Changelog]   - Added Type Alias VariableValuesListForManagementGroupResponse
info	[Changelog]   - Added Type Alias VariableValuesListNextResponse
info	[Changelog]   - Added Type Alias VariableValuesListResponse
info	[Changelog]   - Interface PolicyAssignment has a new optional parameter overrides
info	[Changelog]   - Interface PolicyAssignment has a new optional parameter resourceSelectors
info	[Changelog]   - Interface PolicyAssignmentUpdate has a new optional parameter overrides
info	[Changelog]   - Interface PolicyAssignmentUpdate has a new optional parameter resourceSelectors
info	[Changelog]   - Interface PolicyExemption has a new optional parameter assignmentScopeValidation
info	[Changelog]   - Interface PolicyExemption has a new optional parameter resourceSelectors
info	[Changelog]   - Added Enum KnownAssignmentScopeValidation
info	[Changelog]   - Added Enum KnownOverrideKind
info	[Changelog]   - Added Enum KnownSelectorKind

️✔️@azure/arm-resources-subscriptions [View full logs] [Preview SDK Changes]
- azure-arm-resources-subscriptions-2.1.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️✔️@azure/arm-resources [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-resources-6.0.0.tgz

Only show 14 items here, please refer to log for details.

info	[Changelog]   - Interface TagsDeleteAtScopeOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface TagsDeleteAtScopeOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface TagsUpdateAtScopeOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface TagsUpdateAtScopeOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation TagsOperations.createOrUpdateAtScope
info	[Changelog]   - Removed operation TagsOperations.deleteAtScope
info	[Changelog]   - Removed operation TagsOperations.updateAtScope
info	[Changelog]   - Class ResourceManagementClient has a new signature
info	[Changelog]   - Type of parameter parameters of interface DeploymentProperties is changed from Record<string, unknown> to {
info	[Changelog]         [propertyName: string]: DeploymentParameter;
info	[Changelog]     }

️✔️@azure/arm-templatespecs [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-templatespecs-3.0.0.tgz

Only show 14 items here, please refer to log for details.

info	[Changelog]   - Added Interface TemplateSpecVersionsListBuiltInsNextOptionalParams
info	[Changelog]   - Added Interface TemplateSpecVersionsListBuiltInsOptionalParams
info	[Changelog]   - Added Type Alias TemplateSpecsGetBuiltInResponse
info	[Changelog]   - Added Type Alias TemplateSpecsListBuiltInsNextResponse
info	[Changelog]   - Added Type Alias TemplateSpecsListBuiltInsResponse
info	[Changelog]   - Added Type Alias TemplateSpecVersionsGetBuiltInResponse
info	[Changelog]   - Added Type Alias TemplateSpecVersionsListBuiltInsNextResponse
info	[Changelog]   - Added Type Alias TemplateSpecVersionsListBuiltInsResponse
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Class TemplateSpecsClient has a new signature
info	[Changelog]   - Interface TemplateSpecsListByResourceGroupNextOptionalParams no longer has parameter expand
info	[Changelog]   - Interface TemplateSpecsListBySubscriptionNextOptionalParams no longer has parameter expand

️❌ azure-resource-manager-schemas failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from fc1101b00fd40d3c914f7599b5c99cefc8d68178. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cannot force update branch 'sdkAuto/2934/resources' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/2934/resources' as it is the current HEAD of the repository.

❌resources/resource-manager [View full logs] [Preview Schema Changes]
️✔️resources [View full logs] [Preview Schema Changes]

️✔️resources [View full logs]

error	Fatal error: cannot force update branch 'sdkAuto/2934/resources' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		resources/resource-manager
error		resources
error		resources
error		resources

️✔️resources

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from fc1101b00fd40d3c914f7599b5c99cefc8d68178. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.resources.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.resources.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app-test · 2023-06-20T23:52:51Z

Generated ApiView

Language	Package Name	ApiView Link
Swagger	Microsoft.Resources	https://apiviewstaging.azurewebsites.net/Assemblies/Review/d12796d9616b4af7856bbbca6dad4c33
Go	sdk/resourcemanager/resources/armchanges	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armdeploymentscripts	https://apiviewstaging.azurewebsites.net/Assemblies/Review/18da6978ab64470d82ba30a8db25b80c
Go	sdk/resourcemanager/resources/armfeatures	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armlinks	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armlocks	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armmanagedapplications	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armpolicy	https://apiviewstaging.azurewebsites.net/Assemblies/Review/aaa97086bda14f6180322d8f572459b7
Go	sdk/resourcemanager/resources/armresources	https://apiviewstaging.azurewebsites.net/Assemblies/Review/a4c08d4ed52a48bb945e13eed476208a
Go	sdk/resourcemanager/resources/armsubscriptions	There is no API change compared with the previous version
Go	sdk/resourcemanager/resources/armtemplatespecs	There is no API change compared with the previous version
Java	azure-resourcemanager-resources-generated	https://apiviewstaging.azurewebsites.net/Assemblies/Review/13cb9dcaefc74a26984d09938b18e146
.Net	Azure.ResourceManager.Resources	There is no API change compared with the previous version
JavaScript	@azure/arm-changes	https://apiviewstaging.azurewebsites.net/Assemblies/Review/dbf25332cf6b4812a45d80c1d3634b6f
JavaScript	@azure/arm-features	https://apiviewstaging.azurewebsites.net/Assemblies/Review/a5633c30d4c34e5cbff2cc26b37e2fc9
JavaScript	@azure/arm-links	https://apiviewstaging.azurewebsites.net/Assemblies/Review/a6b2244e646c441184a0069029959c32
JavaScript	@azure/arm-locks	https://apiviewstaging.azurewebsites.net/Assemblies/Review/619f3c1e92f84291a623ed81e39063ea
JavaScript	@azure/arm-managedapplications	https://apiviewstaging.azurewebsites.net/Assemblies/Review/7835480f03fc4aeea060b7922e120244
JavaScript	@azure/arm-policy	https://apiviewstaging.azurewebsites.net/Assemblies/Review/1a0955a0885347b5ab35ecba9ce41dbe
JavaScript	@azure/arm-resources-subscriptions	There is no API change compared with the previous version
JavaScript	@azure/arm-resources	https://apiviewstaging.azurewebsites.net/Assemblies/Review/1140ea0fba7b4148affb8d2f6dfc3e61
JavaScript	@azure/arm-templatespecs	https://apiviewstaging.azurewebsites.net/Assemblies/Review/2a2cd80ea3444e1eb86f4df2c51b2bdc

workflow-bot-test · 2023-06-20T23:58:04Z

Please address or respond to feedback from the ARM API reviewer. When you are ready to continue the ARM API review, please remove the ARMChangesRequested label. This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - https://aka.ms/azsdk/support/specreview-channel.
Please indicate that this is an ARM-related question in the title of your post by including "[ARM Query]" in the title.

workflow-bot-test · 2023-06-20T23:58:04Z

Hi @konrad-jamrozik! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

You cannot proceed with merging this PR until you complete one of the following action items:

ACTION ITEM ALTERNATIVE A: Fix the breaking change.
Please consult the documentation provided in the relevant validation failures.

ACTION ITEM ALTERNATIVE B: Request approval.
Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.

ACTION ITEM ALTERNATIVE C: Report false positive.
If you think there are no breaking changes, i.e. the validation should pass yet it fails, then please explain why in a PR comment and @ the PR assignee.

test ARM spec change

b08c4bc

konrad-jamrozik changed the title ~~[DO NOT MERGE][Internal testing] test ARM spec change~~ [DO NOT MERGE][Internal testing] test ARM spec change - attempt 2 Jun 20, 2023

AzureRestAPISpecReview added ARMChangesRequested ARMReview BreakingChangeReviewRequired ReadyForApiTest resource-manager labels Jun 20, 2023

openapi-pipeline-app-test Bot added the CI-BreakingChange-Go label Jun 21, 2023

openapi-pipeline-app-test Bot added the CI-BreakingChange-JavaScript label Jun 21, 2023

azure-sdk mentioned this pull request Jun 21, 2023

[AutoPR track2_azure-mgmt-resource] [DO NOT MERGE][Internal testing] test ARM spec change - attempt 2 azure-sdk/azure-sdk-for-python#3878

Closed

openapi-pipeline-app-test Bot added the CI-BreakingChange-Python-Track2 label Jun 21, 2023

konrad-jamrozik closed this Jun 21, 2023

konrad-jamrozik changed the title ~~[DO NOT MERGE][Internal testing] test ARM spec change - attempt 2~~ [DO NOT MERGE][Internal testing] test ARM spec change - Test 2 Jun 21, 2023

AzureRestAPISpecReview deleted the users/kojamroz/test_6_20_2023 branch October 1, 2023 02:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE][Internal testing] test ARM spec change - Test 2#2934

[DO NOT MERGE][Internal testing] test ARM spec change - Test 2#2934
konrad-jamrozik wants to merge 1 commit into
mainfrom
users/kojamroz/test_6_20_2023

konrad-jamrozik commented Jun 20, 2023

Uh oh!

openapi-pipeline-app-test Bot commented Jun 20, 2023 •

edited

Loading

Uh oh!

workflow-bot-test Bot commented Jun 20, 2023

Uh oh!

openapi-pipeline-app-test Bot commented Jun 20, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app-test Bot commented Jun 20, 2023 •

edited

Loading

Uh oh!

workflow-bot-test Bot commented Jun 20, 2023

Uh oh!

workflow-bot-test Bot commented Jun 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

konrad-jamrozik commented Jun 20, 2023

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

Due diligence checklist

ARM API changes review

Breaking change review

Getting help

Uh oh!

openapi-pipeline-app-test Bot commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

workflow-bot-test Bot commented Jun 20, 2023

Uh oh!

openapi-pipeline-app-test Bot commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-pipeline-app-test Bot commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

workflow-bot-test Bot commented Jun 20, 2023

Uh oh!

workflow-bot-test Bot commented Jun 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openapi-pipeline-app-test Bot commented Jun 20, 2023 •

edited

Loading

openapi-pipeline-app-test Bot commented Jun 20, 2023 •

edited

Loading

openapi-pipeline-app-test Bot commented Jun 20, 2023 •

edited

Loading