Skip to content
This repository was archived by the owner on Aug 26, 2025. It is now read-only.

Test cadl backward compatibility#2918

Closed
praveenkuttappan wants to merge 3 commits into
mainfrom
test_cadl_backword_compatibility
Closed

Test cadl backward compatibility#2918
praveenkuttappan wants to merge 3 commits into
mainfrom
test_cadl_backword_compatibility

Conversation

@praveenkuttappan
Copy link
Copy Markdown

@praveenkuttappan praveenkuttappan commented Mar 24, 2023

Test backward compatibility

@openapi-pipeline-app-test
Copy link
Copy Markdown

openapi-pipeline-app-test Bot commented Mar 24, 2023 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.
️️✔️~[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand] 
Validation passes for ServiceAPIReadinessTest.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️~[Staging] PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️~[Staging] SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️CadlValidation succeeded [Detail] [Expand] 
Validation passes for CadlValidation.
️❌TypeSpec Validation: 12 Errors, 28 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ unknown-identifier Unknown identifier Cadl
Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L9
❌ unknown-identifier Unknown identifier Cadl
Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L10
❌ unknown-identifier Unknown identifier Cadl
Location: specification/cognitiveservices/OpenAI.Authoring/finetune.tsp#L93
❌ unknown-decorator Unknown decorator
Location: specification/cognitiveservices/OpenAI.Authoring/finetune.tsp#L93
❌ unknown-identifier Unknown identifier route
Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L27
❌ unknown-decorator Unknown decorator
Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L27
❌ unknown-identifier Unknown identifier get
Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L28
❌ unknown-decorator Unknown decorator
Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L28
❌ InConsistentSwagger "details":"The generated swagger file v1.1/openapi.json from typespec specification/cognitiveservices/AnomalyDetector is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/cognitiveservices/data-plane/AnomalyDetector/stable/v1.1/openapi.json' in PR,
please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log."
❌ MissingExamplesDirectory "details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Authoring,
please ensure the 'examples' is added in the PR."
❌ MissingExamplesDirectory "details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Inference,
please ensure the 'examples' is added in the PR."
❌ InConsistentSwagger "details":"The generated swagger file v1.1/openapi.json from typespec specification/cognitiveservices/OpenAI.Inference is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/cognitiveservices/data-plane/AnomalyDetector/stable/v1.1/openapi.json' in PR,
please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log."
⚠️ @azure-tools/typespec-azure-core/use-extensible-enum Enums should be defined without the @fixed decorator.
Location: cognitiveservices/AnomalyDetector/univariate/models.tsp#L34
⚠️ @azure-tools/typespec-azure-core/casing-style The names of Property types must use camelCase
Location: cognitiveservices/AnomalyDetector/univariate/models.tsp#L176
⚠️ @azure-tools/typespec-azure-core/use-standard-operations Operation 'DetectUnivariateEntireSeries' should be defined using a signature from the Azure.Core namespace.
Location: cognitiveservices/AnomalyDetector/univariate/routes.tsp#L11
⚠️ @azure-tools/typespec-azure-core/use-standard-operations Operation 'DetectUnivariateLastPoint' should be defined using a signature from the Azure.Core namespace.
Location: cognitiveservices/AnomalyDetector/univariate/routes.tsp#L26
⚠️ @azure-tools/typespec-azure-core/use-standard-operations Operation 'DetectUnivariateChangePoint' should be defined using a signature from the Azure.Core namespace.
Location: cognitiveservices/AnomalyDetector/univariate/routes.tsp#L39
⚠️ @azure-tools/typespec-azure-core/use-extensible-enum Enums should be defined without the @fixed decorator.
Location: cognitiveservices/AnomalyDetector/multivariate/models.tsp#L21
⚠️ @azure-tools/typespec-azure-core/casing-style The names of Property types must use camelCase
Location: cognitiveservices/AnomalyDetector/multivariate/models.tsp#L100
⚠️ @azure-tools/typespec-azure-core/casing-style The names of Property types must use camelCase
Location: cognitiveservices/AnomalyDetector/multivariate/models.tsp#L390
⚠️ @azure-tools/typespec-azure-core/use-extensible-enum Enums should be defined without the @fixed decorator.
Location: cognitiveservices/AnomalyDetector/multivariate/models.tsp#L37
⚠️ @azure-tools/typespec-azure-core/casing-style The names of Property types must use camelCase
Location: cognitiveservices/AnomalyDetector/multivariate/models.tsp#L268
⚠️ @azure-tools/typespec-azure-core/use-extensible-enum Enums should be defined without the @fixed decorator.
Location: cognitiveservices/AnomalyDetector/multivariate/models.tsp#L43
⚠️ @azure-tools/typespec-azure-core/use-standard-operations Operation 'GetMultivariateBatchDetectionResult' should be defined using a signature from the Azure.Core namespace.
Location: cognitiveservices/AnomalyDetector/multivariate/routes.tsp#L11
⚠️ @azure-tools/typespec-azure-core/use-standard-operations Operation 'TrainMultivariateModel' should be defined using a signature from the Azure.Core namespace.
Location: cognitiveservices/AnomalyDetector/multivariate/routes.tsp#L26
⚠️ @azure-tools/typespec-azure-core/casing-style The names of Property types must use camelCase
Location: cognitiveservices/AnomalyDetector/multivariate/routes.tsp#L44
⚠️ @azure-tools/typespec-azure-core/use-standard-operations Operation 'ListMultivariateModels' should be defined using a signature from the Azure.Core namespace.
Location: cognitiveservices/AnomalyDetector/multivariate/routes.tsp#L49
⚠️ @azure-tools/typespec-azure-core/use-standard-operations Operation 'DeleteMultivariateModel' should be defined using a signature from the Azure.Core namespace.
Location: cognitiveservices/AnomalyDetector/multivariate/routes.tsp#L65
⚠️ @azure-tools/typespec-azure-core/use-standard-operations Operation 'GetMultivariateModel' should be defined using a signature from the Azure.Core namespace.
Location: cognitiveservices/AnomalyDetector/multivariate/routes.tsp#L80
⚠️ @azure-tools/typespec-azure-core/use-standard-operations Operation 'DetectMultivariateBatchAnomaly' should be defined using a signature from the Azure.Core namespace.
Location: cognitiveservices/AnomalyDetector/multivariate/routes.tsp#L94
Posted by Swagger Pipeline | How to fix these errors?

@workflow-bot-test
Copy link
Copy Markdown

workflow-bot-test Bot commented Mar 24, 2023

Hi, @praveenkuttappan Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app-test
    Copy link
    Copy Markdown

    openapi-pipeline-app-test Bot commented Mar 24, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️~[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs] Generate from 381dae3eaf52adfe8892698d098cf928422a2e48. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.3` to update!
cmderr	[automation_generate.sh] npm notice
warn	No file changes detected after generation
warn	No package detected after generation
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 381dae3eaf52adfe8892698d098cf928422a2e48. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • ❌Code Generator Failed [Logs] Generate from 381dae3eaf52adfe8892698d098cf928422a2e48. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mException: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:133
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 133 | �[0m             �[36;1mthrow "Not provide service name or namespace."�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mNot provide service name or namespace.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1
warn	Skip package processing as generation is failed
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app-test
    Copy link
    Copy Markdown

    openapi-pipeline-app-test Bot commented Mar 24, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    TypeSpec AnomalyDetector https://apiviewstaging.azurewebsites.net/Assemblies/Review/a7dbf299a58c46639e5f0cab81380736

    @praveenkuttappan praveenkuttappan changed the title Test cadl backword compatibility Test cadl backward compatibility Mar 24, 2023
    @praveenkuttappan
    Copy link
    Copy Markdown
    Author

    praveenkuttappan commented Mar 24, 2023

    /azp run

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Mar 24, 2023

    No pipelines are associated with this pull request.

    @praveenkuttappan
    Copy link
    Copy Markdown
    Author

    praveenkuttappan commented Mar 30, 2023

    /azp run

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Mar 30, 2023

    No pipelines are associated with this pull request.

    @praveenkuttappan
    Copy link
    Copy Markdown
    Author

    praveenkuttappan commented Mar 31, 2023

    /azp run

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Mar 31, 2023

    No pipelines are associated with this pull request.

    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @praveenkuttappan @konrad-jamrozik