Skip to content
This repository was archived by the owner on Aug 26, 2025. It is now read-only.

add new version#1934

Closed
jianyexi wants to merge 0 commit into
masterfrom
add_pr
Closed

add new version#1934
jianyexi wants to merge 0 commit into
masterfrom
add_pr

Conversation

@jianyexi
Copy link
Copy Markdown

@jianyexi jianyexi commented Nov 2, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app-test
Copy link
Copy Markdown

openapi-pipeline-app-test Bot commented Nov 2, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail]
There are no breaking changes.
️❌~[Staging] LintDiff: 6 Errors, 50 Warnings failed [Detail] [Expand] Only 10 items are listed, please refer to log for more details.

Rule Message
D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'ContentType_Delete'
New: Microsoft.ApiManagement/stable/2019-12-01/apimcontenttypes.json#L234
D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'ContentItem_GetEntityTag'
New: Microsoft.ApiManagement/stable/2019-12-01/apimcontenttypes.json#L319
D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'ContentItem_Delete'
New: Microsoft.ApiManagement/stable/2019-12-01/apimcontenttypes.json#L479
D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'ContentType_GetEntityTag'
New: Microsoft.ApiManagement/stable/2019-12-01/apimcontenttypes.json#L83
R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
New: Microsoft.ApiManagement/stable/2019-12-01/apimcontenttypes.json#L257
R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
New: Microsoft.ApiManagement/stable/2019-12-01/apimcontenttypes.json#L505
⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'tenant' with immediate parent 'ApiManagementServiceResource', must have a list by immediate parent operation.
New: Microsoft.ApiManagement/stable/2019-12-01/definitions.json#L37
⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'tags' with immediate parent 'ApiManagementServiceResource', must have a list by immediate parent operation.
New: Microsoft.ApiManagement/stable/2019-12-01/definitions.json#L37
⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'subscriptions' with immediate parent 'ApiManagementServiceResource', must have a list by immediate parent operation.
New: Microsoft.ApiManagement/stable/2019-12-01/definitions.json#L37
️❌~[Staging] Avocado: 702 Errors, 0 Warnings failed [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/apimanagement/resource-manager/readme.md
json: Microsoft.ApiManagement/preview/2020-06-01-preview/apimanagement.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/apimanagement/resource-manager/readme.md
json: Microsoft.ApiManagement/preview/2020-06-01-preview/apimapis.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/apimanagement/resource-manager/readme.md
json: Microsoft.ApiManagement/preview/2020-06-01-preview/apimapisByTags.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/apimanagement/resource-manager/readme.md
json: Microsoft.ApiManagement/preview/2020-06-01-preview/apimapiversionsets.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/apimanagement/resource-manager/readme.md
json: Microsoft.ApiManagement/preview/2020-06-01-preview/apimauthorizationservers.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/apimanagement/resource-manager/readme.md
json: Microsoft.ApiManagement/preview/2020-06-01-preview/apimbackends.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/apimanagement/resource-manager/readme.md
json: Microsoft.ApiManagement/preview/2020-06-01-preview/apimcaches.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/apimanagement/resource-manager/readme.md
json: Microsoft.ApiManagement/preview/2020-06-01-preview/apimcertificates.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/apimanagement/resource-manager/readme.md
json: Microsoft.ApiManagement/preview/2020-06-01-preview/apimcontenttypes.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/apimanagement/resource-manager/readme.md
json: Microsoft.ApiManagement/preview/2020-06-01-preview/apimdeletedservices.json
️⌛~[Staging] ModelValidation pending [Detail] [Expand]
️❌~[Staging] SemanticValidation: 1 Errors, 0 Warnings failed [Detail] [Expand]
Rule Message
MISSING_PATH_PARAMETER_DEFINITION Path parameter is declared but is not defined: resourceGroupName
JsonUrl: Microsoft.ApiManagement/preview/2020-12-02-preview/apimgateways.json#L38
️⚠️~[Staging] Cross Version BreakingChange (Base on preview version): 43 Warnings warning [Detail] [Expand] Only 10 items are listed, please refer to log for more details.

Rule Message
⚠️ 1009 - RemovedRequiredParameter The required parameter 'If-Match' was removed in the new version.
New: azure-rest-api-specs/blob/0311f17576e712a7d17d43dc9d22c5860a63cb91/
Old: Microsoft.ApiManagement/preview/2020-06-01-preview/apimgateways.json#L775:9
⚠️ 1009 - RemovedRequiredParameter The required parameter 'resourceGroupName' was removed in the new version.
New: azure-rest-api-specs/blob/0311f17576e712a7d17d43dc9d22c5860a63cb91/
Old: Microsoft.ApiManagement/preview/2020-06-01-preview/apimgateways.json#L108:9
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tls10Enabled' renamed or removed?
New: Microsoft.ApiManagement/preview/2020-12-02-preview/definitions.json#L5516:7
Old: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L5700:7
️⚠️~[Staging] Cross Version BreakingChange (Base on stable version): 1 Warnings warning [Detail] [Expand]

Rule Message
⚠️ 1009 - RemovedRequiredParameter The required parameter 'resourceGroupName' was removed in the new version.
New: azure-rest-api-specs/blob/0311f17576e712a7d17d43dc9d22c5860a63cb91/
Old: Microsoft.ApiManagement/stable/2019-12-01/apimgateways.json#L100:9
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link
Copy Markdown

openapi-pipeline-app-test Bot commented Nov 2, 2020

Swagger Generation Artifacts

️🔄~[Staging] ApiDocPreview inProgress [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@jianyexi
Copy link
Copy Markdown
Author

jianyexi commented Nov 2, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@jianyexi
Copy link
Copy Markdown
Author

jianyexi commented Nov 2, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-net that referenced this pull request Nov 2, 2020
Merge 0311f17576e712a7d17d43dc9d22c5860a63cb91 into f6d21a3a1b247f32c5dafa4f530f16465fd510f6
openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-js that referenced this pull request Nov 2, 2020
Merge 0311f17576e712a7d17d43dc9d22c5860a63cb91 into f6d21a3a1b247f32c5dafa4f530f16465fd510f6
@azure-sdk azure-sdk force-pushed the master branch 8 times, most recently from a205bb0 to 65a8880 Compare November 6, 2020 03:04
@zhenglaizhang
Copy link
Copy Markdown

zhenglaizhang commented Nov 6, 2020

Hi @${PRAuthor}, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback."

@azure-sdk azure-sdk force-pushed the master branch 12 times, most recently from 5a1d409 to 706496b Compare November 17, 2020 03:09
@azure-sdk azure-sdk force-pushed the master branch 4 times, most recently from 60b23e4 to ded7843 Compare November 19, 2020 03:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants