Skip to content
This repository was archived by the owner on Aug 26, 2025. It is now read-only.

old2#1916

Closed
zhenglaizhang wants to merge 0 commit into
masterfrom
zhenglaizhang-patch-3
Closed

old2#1916
zhenglaizhang wants to merge 0 commit into
masterfrom
zhenglaizhang-patch-3

Conversation

@zhenglaizhang

Copy link
Copy Markdown

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app-test

openapi-pipeline-app-test Bot commented Oct 28, 2020

Copy link
Copy Markdown

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail] [Expand]
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'ConfigurationStores_Create' to 'ConfigurationStores_CreatdadADSVe'. This will impact generated code.
New: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L154:7
Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L154:7
️⚠️~[Staging] LintDiff: 2 Warnings warning [Detail] [Expand]
Rule Message
⚠️ R1006 - PutInOperationName 'PUT' operation 'ConfigurationStores_CreatdadADSVe' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
New: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L159
⚠️ R4009 - RequiredSystemDataInNewApiVersions The response of operation:'ConfigurationStores_CreatdadADSVe' is defined without 'systemData'. Consider adding the systemData to the response.
New: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L154
️️✔️~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test

openapi-pipeline-app-test Bot commented Oct 28, 2020

Copy link
Copy Markdown

Swagger Generation Artifacts

️️✔️~[Staging] ApiDocPreview succeeded [Detail]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-bot

openapi-pipeline-bot Bot commented Oct 28, 2020

Copy link
Copy Markdown

Swagger Validation Report

BreakingChange: 1 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'ConfigurationStores_Create' to 'ConfigurationStores_CreatdadADSVe'. This will impact generated code.
New: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L154:7
Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L154:7
⚠️LintDiff: 2 Warnings [Detail] [Expand]
Rule Message
⚠️ R1006 - PutInOperationName 'PUT' operation 'ConfigurationStores_CreatdadADSVe' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
New: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L159
⚠️ R4009 - RequiredSystemDataInNewApiVersions The response of operation:'ConfigurationStores_CreatdadADSVe' is defined without 'systemData'. Consider adding the systemData to the response.
New: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L154
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
️✔️CrossVersionBreakingChangePreview [Detail]
 There are no breaking changes. 
️✔️CrossVersionBreakingChangeStable [Detail]
Posted by Swagger Pipeline | How to fix these errors?

openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-js that referenced this pull request Oct 28, 2020
Merge 3ea0fb76253232c325e3b2e5e15e31125260666f into 72fbf6c3668918bb0d08fa34bdffa2ccec8d6b9d
openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-net that referenced this pull request Oct 28, 2020
Merge 3ea0fb76253232c325e3b2e5e15e31125260666f into 72fbf6c3668918bb0d08fa34bdffa2ccec8d6b9d
openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 3ea0fb76253232c325e3b2e5e15e31125260666f into 72fbf6c3668918bb0d08fa34bdffa2ccec8d6b9d
openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 3ea0fb76253232c325e3b2e5e15e31125260666f into 72fbf6c3668918bb0d08fa34bdffa2ccec8d6b9d
openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 3ea0fb76253232c325e3b2e5e15e31125260666f into 72fbf6c3668918bb0d08fa34bdffa2ccec8d6b9d
openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 3ea0fb76253232c325e3b2e5e15e31125260666f into 72fbf6c3668918bb0d08fa34bdffa2ccec8d6b9d
@azure-sdk azure-sdk force-pushed the master branch 11 times, most recently from a7a0d0d to 6151add Compare November 4, 2020 15:01
@azure-sdk azure-sdk force-pushed the master branch 4 times, most recently from 65a8880 to 95a8b02 Compare November 6, 2020 15:01
@azure-sdk azure-sdk force-pushed the master branch 13 times, most recently from 61004f9 to cbe9064 Compare November 16, 2020 03:01
@azure-sdk azure-sdk force-pushed the master branch 6 times, most recently from 60b23e4 to ded7843 Compare November 19, 2020 03:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant