Skip to content
This repository was archived by the owner on Aug 26, 2025. It is now read-only.

[TestUnifiedPipeline] [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01#1877

Closed
zhenglaizhang wants to merge 0 commit into
test-repo-billy:masterfrom
brpanask:dev-storagecache-Microsoft.StorageCache-2020-10-01
Closed

[TestUnifiedPipeline] [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01#1877
zhenglaizhang wants to merge 0 commit into
test-repo-billy:masterfrom
brpanask:dev-storagecache-Microsoft.StorageCache-2020-10-01

Conversation

@zhenglaizhang
Copy link
Copy Markdown

Mirror from https://github.com/Azure/azure-rest-api-specs/pull/11407

@openapi-pipeline-app-test
Copy link
Copy Markdown

openapi-pipeline-app-test Bot commented Oct 27, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 16 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

Rule Message
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: toBeExportedForShoebox
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L2230
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: rootSquash
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1648
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: submountAccess
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1644
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: suid
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1640
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoDownloadCertificate
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1553
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: requireValidCertificate
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1549
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: encryptLdapConnection
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1545
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: extendedGroupsEnabled
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1510
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1116
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 64 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

Rule Message
⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'StorageTargets_Create' to 'StorageTargets_CreateOrUpdate'. This will impact generated code.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L937:7
Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L854:7
⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Caches_Create' to 'Caches_CreateOrUpdate'. This will impact generated code.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L417:7
Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L364:7
⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L725:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L468:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L661:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L597:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1059:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L996:11
⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1937:5
Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1351:5
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 4 Warnings warning [Detail]

Rule Message
⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L468:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L996:11
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'rootSquash' renamed or removed?
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1417:7
Old: Microsoft.StorageCache/stable/2020-03-01/storagecache.json#L1361:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'rootSquash' renamed or removed?
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1417:7
Old: Microsoft.StorageCache/stable/2020-03-01/storagecache.json#L1361:7
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link
Copy Markdown

openapi-pipeline-app-test Bot commented Oct 27, 2020

Swagger Generation Artifacts

️🔄~[Staging] ApiDocPreview inProgress [Detail]
Posted by Swagger Pipeline | How to fix these errors?

openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 88683cd03b1f2ce7fdc32d2fede4d02fa719aa76 into 520a3e18b63cbd1abe5d5faad22ef717493ba77b
openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 88683cd03b1f2ce7fdc32d2fede4d02fa719aa76 into 520a3e18b63cbd1abe5d5faad22ef717493ba77b
openapi-sdkautomation-test Bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Oct 28, 2020
Merge 88683cd03b1f2ce7fdc32d2fede4d02fa719aa76 into 520a3e18b63cbd1abe5d5faad22ef717493ba77b
@azure-sdk azure-sdk force-pushed the master branch 4 times, most recently from 9ab6563 to 06ea37f Compare October 30, 2020 15:02
@brpanask brpanask force-pushed the dev-storagecache-Microsoft.StorageCache-2020-10-01 branch from 88683cd to 6396339 Compare October 30, 2020 17:56
@azure-sdk azure-sdk force-pushed the master branch 9 times, most recently from c170708 to a205bb0 Compare November 5, 2020 15:03
@azure-sdk azure-sdk force-pushed the master branch 11 times, most recently from 14405b1 to 031edd2 Compare November 13, 2020 03:02
@azure-sdk azure-sdk force-pushed the master branch 10 times, most recently from 60b23e4 to ded7843 Compare November 19, 2020 03:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant