Support Windows 2016 #291
Support Windows 2016 #291
Conversation
AWS has replaced EC2Config with EC2Launch on Windows 2016. http://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/ec2launch.html
Rubocop 0.28 requires rake < 12
| @@ -8,7 +8,7 @@ gem "winrm-fs" | |||
| gem "activesupport", "~> 4.0" | |||
|
|
|||
| group :test do | |||
| gem "rake" | |||
| gem "rake", "< 12" | |||
There was a problem hiding this comment.
Any reason for this particular pin?
There was a problem hiding this comment.
Rake 12 isn't compatible with rubocop 0.28, which is pinned by finstyle 1.4.0.
And the gemspec file says
style and complexity libraries are tightly version pinned as newer releases may introduce new and undesireable style choices which would be immediately enforced in CI
There was a problem hiding this comment.
I just tried updating to finstyle 1.5.0. It still isn't compatible with rake 12, and it picks up 11 more style offences :)
There was a problem hiding this comment.
We're moving away from finstyle and I didn't realize this repo was still on it so new things to do
.travis.yml
Outdated
| - 2.0.0 | ||
| - 2.1 | ||
| - 2.2 | ||
| - 2.1.8 |
There was a problem hiding this comment.
Safe to drop 2.1.x and keep somewhat in line with https://github.com/test-kitchen/test-kitchen/blob/master/.travis.yml#L3-L6
|
Aside from the inline comments this look great! |
AWS has changed a number of characteristics of Windows Server 2016 instances:
Windows_Server-2016-English-<Style>-*, where<Style>is one ofFull-Basefor regular servers,Nano-Basefor Nano servers, orFull-Containersfor server with containersEC2Launchinstead ofEC2Confighttp://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/windows-ami-version-history.html#win2k16-amis