Fix #268 #269
Merged
Fix #268 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,7 +69,7 @@ class Ec2 < Kitchen::Driver::Base # rubocop:disable Metrics/ClassLength | |||
| default_config :aws_access_key_id, nil | |||
| default_config :aws_secret_access_key, nil | |||
| default_config :aws_session_token, nil | |||
| default_config :aws_ssh_key_id, ENV["AWS_SSH_KEY_ID"] | |||
| default_config :aws_ssh_key_id, ENV["AWS_SSH_KEY_ID"] || nil | |||
|
besides the nit above. I think this is a good move but we need to fix the tests. |
|
Fixed tests and all succeed locally with 'chef exec rake test' (see below). Travis CI build is not working due to mismatch of dependencies in Travis build environment: Output of local tests |
|
Is there anything else I can do to facilitate acceptance of this PR? |
|
I just submited PR #272 which once merged should get this green. |
|
I reran the travis test after merging #272 and its green now so I'm 👍 |
|
Awesome! I don't see that LGTM quorum is required for this repo, but once this is merged, is there a Travis hook to publish to rubygems.org? |
|
So we need to fix this repo but all the kitchen-* plugins maintained by @tk-core require two +1s but I think we only have that on the core repo at the moment. +1 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I trouble running the test cases, but added a new case for "minimum" ec2 instance (without aws_ssh_key_id specified).