-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to wasmtime v22.0.0 #599
Conversation
ok, wow! I was having a bit of a hard time updating wasmtime and you just handed a PR in doing that 💛 |
32d1abd
to
800dea6
Compare
@tessi @RoyalIcing ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, very happy to have the latest wasmtime in. I will defer approval on this one to @tessi as I confess to some ignorance on WebAssembly post its MVC, I’m not super knowledgable on refs yet.
fn val_type_to_atom(val_type: &ValType) -> Atom { | ||
match val_type { | ||
ValType::I32 => atoms::i32(), | ||
ValType::I64 => atoms::i64(), | ||
ValType::F32 => atoms::f32(), | ||
ValType::F64 => atoms::f64(), | ||
ValType::V128 => atoms::v128(), | ||
ValType::ExternRef => atoms::extern_ref(), | ||
ValType::FuncRef => atoms::func_ref(), | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making this a proper enum with a From
impl! looks much cleaner than what I wrote
expected = %{"myTable" => {:table, %{minimum: 2, type: :func_ref}}} | ||
expected = %{"myTable" => {:table, %{minimum: 2, type: {:reference, "(ref null func)"}}}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
looks great to me. thanks a ton @scrogson - I love how you not only upgraded wasmtime but also made wasmex a bit easier to debug 💚 also thanks @RoyalIcing for having a look and review too 💛 |
Wasmtime 22 changelog: https://github.com/bytecodealliance/wasmtime/blob/release-22.0.0/RELEASES.md
Closes: #575
Closes: #576
Closes: #577
Closes: #580
Closes: #583
Closes: #588
Closes: #589
Closes: #590
Closes: #591