Improve the DebugDump output by slightly adjusting the format. #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… numeric columns, which was 3,3,3,3 and overflowing in our test runs, damaging the table layout. See rationale in the code comment: ------ // The largest (positive and negative) numbers are reported for lindent & rindent. // While the column header has widths 5,4,4,5, it is therefore opportune to slightly // offset the widths in the format string here to allow ample space for lindent & rindent // while keeeping the final table output nicely readable: 4,5,5,4. # Conflicts: # src/ccmain/paragraphs.cpp
stweil
reviewed
Feb 25, 2023
src/ccmain/paragraphs.cpp
Outdated
| // The largest (positive and negative) numbers are reported for lindent & rindent. | ||
| // While the column header has widths 5,4,4,5, it is therefore opportune to slightly | ||
| // offset the widths in the format string here to allow ample space for lindent & rindent | ||
| // while keeeping the final table output nicely readable: 4,5,5,4. |
There was a problem hiding this comment.
Suggested change
| // while keeeping the final table output nicely readable: 4,5,5,4. | |
| // while keeping the final table output nicely readable: 4,5,5,4. |
|
Thanks! (old age & a fast keyboard :'-( )
Met vriendelijke groeten / Best regards,
Ger Hobbelt
…--------------------------------------------------
web: http://www.hobbelt.com/
http://www.hebbut.net/
mail: ***@***.***
mobile: +31-6-11 120 978
--------------------------------------------------
On Sat, Feb 25, 2023 at 3:25 PM Stefan Weil ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/ccmain/paragraphs.cpp
<#4022 (comment)>
:
> @@ -514,8 +514,12 @@ void RowScratchRegisters::AppendDebugHeaderFields(std::vector<std::string> &head
void RowScratchRegisters::AppendDebugInfo(const ParagraphTheory &theory,
std::vector<std::string> &dbg) const {
- char s[30];
- snprintf(s, sizeof(s), "[%3d,%3d;%3d,%3d]", lmargin_, lindent_, rindent_, rmargin_);
+ char s[60];
+ // The largest (positive and negative) numbers are reported for lindent & rindent.
+ // While the column header has widths 5,4,4,5, it is therefore opportune to slightly
+ // offset the widths in the format string here to allow ample space for lindent & rindent
+ // while keeeping the final table output nicely readable: 4,5,5,4.
⬇️ Suggested change
- // while keeeping the final table output nicely readable: 4,5,5,4.
+ // while keeping the final table output nicely readable: 4,5,5,4.
—
Reply to this email directly, view it on GitHub
<#4022 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADCIHUZZYCNPO2Z6MMSQKTWZII5JANCNFSM6AAAAAAVH4KPGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the DebugDump output by slightly adjusting the format for the numeric columns, which was 3,3,3,3 and overflowing in our test runs, damaging the table layout. See rationale in the code comment:
// The largest (positive and negative) numbers are reported for lindent & rindent.
// While the column header has widths 5,4,4,5, it is therefore opportune to slightly
// offset the widths in the format string here to allow ample space for lindent & rindent
// while keeeping the final table output nicely readable: 4,5,5,4.
Conflicts:
src/ccmain/paragraphs.cpp
Sample output: (BTW: note the '1270' in there, which previously pushed the table layout out of whack)