Prevent uninitialized integer from being used for x_fsize output #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If font_name is false, then res_it->WordFontAttributes and pointsize is uninitialized. This results in seemingly random data being written to the hocr output for x_fsize.
|
Do you have a simple test case where there is no |
|
I'm sorry but that's not the right solution. |
|
Here is Ray's suggestion: And here is mine: |
Actually, it's better to use function overloading for RowAttributes() to not break the C++ API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If font_name is false, then res_it->WordFontAttributes and pointsize is uninitialized. This results in seemingly random data being written to the hocr output for x_fsize. This change moves the output of x_fsize into the check that verifies the function that initializes pointsize actually ran, preventing the output of the uninitialized value.