fixed the error dialogue boxes to match best practice as specified on ht... #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
| input(name='password', type='password', placeholder='password') | ||
| .large-6.columns.end(class="#{loginErr ? 'error' : ''}") | ||
| label(for="username") Password | ||
| input(name='password', type='password', placeholder='password' id='username') |
There was a problem hiding this comment.
are we using id for anything? should it be username or 'password' here?
|
@"are we using id for anything? should it be username or 'password' here?" We set the id attribute so the label is associated the the input. Right now clicking the label highlights the input because the label is the parent of the input field. If we change that in the future, setting the id will guarantee that clicking the label will highlight the input. |
jiahuang
added a commit
that referenced
this pull request
Nov 17, 2014
fixed the error dialogue boxes to match best practice as specified on ht...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed styling to match
http://foundation.zurb.com/docs/components/abide.html
solved #194
reviewed by: @jiahuang @Frijol