Nl replaced sync library #16
Conversation
|
|
||
| var DEBUG = false; | ||
| var COMPRESSION_RANGE = 255; | ||
|
|
||
| var queue = new Queue(); |
There was a problem hiding this comment.
It seems like this queue should be a property of the Camera object, right? Each port as a different UART bus so those signals can't interfere with each other and the SPI bus has a queue of its own.
There was a problem hiding this comment.
I agree. I was wondering about the SPI bus stuff tho. If there is a shared spi bus then I think that each camera instance should share the same queue otherwise two instances might call take picture at the same time and cause issues. What are your thoughts?
There was a problem hiding this comment.
We have a SPI queue in the Tessel driver that should prevent that from happening. If a SPI request is already underway, the second call to takePicture would be queued up until the first completes.
There was a problem hiding this comment.
Other than that, works well! r+ after moving queue inside the object.
There was a problem hiding this comment.
Noice! Thats good thinking building an internal SPI queue.
There was a problem hiding this comment.
queue is part of camera object now.
|
r+ |
Replaced the sync-q library with my own synchronous queue library named - sink_q
Race conditions are fixed so users can call take picture without manually interleaving callbacks
Reviewed By: @johnnyman727